diff options
| author | bors <bors@rust-lang.org> | 2021-09-11 23:35:28 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2021-09-11 23:35:28 +0000 |
| commit | 8743472386095d8d6f2e2757958f71879d9dfe84 (patch) | |
| tree | ec0e0843f2cf9df79b9bd59fbaaa32360dc7deea /tests/codegen/src-hash-algorithm/src-hash-algorithm-md5.rs | |
| parent | e014277b07049f0638662f4040c2af7b119cc8a4 (diff) | |
| parent | 127ec9a8c94419669b22079c988e38638b58395f (diff) | |
| download | rust-8743472386095d8d6f2e2757958f71879d9dfe84.tar.gz rust-8743472386095d8d6f2e2757958f71879d9dfe84.zip | |
Auto merge of #84373 - cjgillot:resolve-span, r=michaelwoerister,petrochenkov
Encode spans relative to the enclosing item The aim of this PR is to avoid recomputing queries when code is moved without modification. MCP at https://github.com/rust-lang/compiler-team/issues/443 This is achieved by : 1. storing the HIR owner LocalDefId information inside the span; 2. encoding and decoding spans relative to the enclosing item in the incremental on-disk cache; 3. marking a dependency to the `source_span(LocalDefId)` query when we translate a span from the short (`Span`) representation to its explicit (`SpanData`) representation. Since all client code uses `Span`, step 3 ensures that all manipulations of span byte positions actually create the dependency edge between the caller and the `source_span(LocalDefId)`. This query return the actual absolute span of the parent item. As a consequence, any source code motion that changes the absolute byte position of a node will either: - modify the distance to the parent's beginning, so change the relative span's hash; - dirty `source_span`, and trigger the incremental recomputation of all code that depends on the span's absolute byte position. With this scheme, I believe the dependency tracking to be accurate. For the moment, the spans are marked during lowering. I'd rather do this during def-collection, but the AST MutVisitor is not practical enough just yet. The only difference is that we attach macro-expanded spans to their expansion point instead of the macro itself.
Diffstat (limited to 'tests/codegen/src-hash-algorithm/src-hash-algorithm-md5.rs')
0 files changed, 0 insertions, 0 deletions
