diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2024-05-02 19:42:48 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-05-02 19:42:48 +0200 |
| commit | e9e2ebb051b5b108973b02f80cb5531a213a865b (patch) | |
| tree | 5e8bef97aae4cc1f785e678852e380076f51ce76 /tests/coverage/branch/let-else.rs | |
| parent | f01e99f1914e17146606637821c0807df76950dd (diff) | |
| parent | 1367827eac3d813a261a4c444037af9736996daa (diff) | |
| download | rust-e9e2ebb051b5b108973b02f80cb5531a213a865b.tar.gz rust-e9e2ebb051b5b108973b02f80cb5531a213a865b.zip | |
Rollup merge of #124414 - lqd:subdiagnostics, r=davidtwco
remove extraneous note on `UnableToRunDsymutil` diagnostic If I understand [this FIXME](https://github.com/rust-lang/rust/blob/1367827eac3d813a261a4c444037af9736996daa/compiler/rustc_macros/src/diagnostics/diagnostic.rs#L205) correctly, it seems we don't yet validate subdiagnostics, so `#[note]` and co in the `#[derive(Diagnostic]` item could be out-of-sync with the fluent message, without causing compile errors. It was the case for `rustc_codegen_ssa::errors::UnableToRunDsymutil`, causing the ICE in #124392. I've grepped and scripted my way through most of our diagnostics structs and fluent bundles and the above was the only such extraneous `#[note]`/`#[note(name)]`/`#[help]`/`#[warning]` I could find, so hopefully there aren't many others like it. I haven't checked if the opposite can happen, a `.note = ` in a fluent message that is lacking a corresponding `#[note]` on the struct and not causing an error, but maybe it's possible? r? ``@davidtwco`` fixes #124392
Diffstat (limited to 'tests/coverage/branch/let-else.rs')
0 files changed, 0 insertions, 0 deletions