diff options
| author | bors <bors@rust-lang.org> | 2018-12-17 10:48:16 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2018-12-17 10:48:16 +0000 |
| commit | 091fd0360b0f457ff77ba85d7a01ff39e26677eb (patch) | |
| tree | 2dd6d565c508b1e14effd1d2675ecaa0f8152458 /tests/mir-opt/lower_array_len.array_len_raw.NormalizeArrayLen.diff | |
| parent | a416c5e0f7c4c9473069a58410d3ec3e86b1ac0d (diff) | |
| parent | 6870638c3fb66c2abb20633bf40cc09ccc760047 (diff) | |
| download | rust-091fd0360b0f457ff77ba85d7a01ff39e26677eb.tar.gz rust-091fd0360b0f457ff77ba85d7a01ff39e26677eb.zip | |
Auto merge of #3555 - daxpedda:master, r=oli-obk
Fix `implicit_return` false positives. Fixing some false positives on the `implicit_return` lint. Basically it should only check for missing return statements in `block.stmts.last()` if it's a `break`, otherwise it should skip because it would either be an error, or a false positive in the case of a `loop` (which I'm trying to fix with this PR). **Question:** - I say "we" inside of comments ([`// make sure it's a break, otherwise we want to skip`](https://github.com/rust-lang/rust-clippy/pull/3555/files#diff-11d233fe8c8414214c2b8732b8c9877aR71)). Any alternatives or is that okay? - I named a test [`test_loop_with_nests()`](https://github.com/rust-lang/rust-clippy/blob/6870638c3fb66c2abb20633bf40cc09ccc760047/tests/ui/implicit_return.rs#L54-L64), any better suggestions?
Diffstat (limited to 'tests/mir-opt/lower_array_len.array_len_raw.NormalizeArrayLen.diff')
0 files changed, 0 insertions, 0 deletions