diff options
| author | bors <bors@rust-lang.org> | 2023-08-23 07:20:41 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2023-08-23 07:20:41 +0000 |
| commit | edfee16ade1d4af7fa33e34e39ff443cbdd7ffe9 (patch) | |
| tree | 108412f2c83d0c00869c893bf5667b4d4b6c5815 /tests/rustdoc-js-std/parser-paths.js | |
| parent | 4be90d03052c8f2bcb1e55af340dd73a4e399cce (diff) | |
| parent | f0eaa662632c8e85b07063507930dc77fdd3e1e3 (diff) | |
| download | rust-edfee16ade1d4af7fa33e34e39ff443cbdd7ffe9.tar.gz rust-edfee16ade1d4af7fa33e34e39ff443cbdd7ffe9.zip | |
Auto merge of #11379 - popzxc:fix-tuple-array-conversions, r=xFrednet
Fix tuple_array_conversions lint on nightly
```
changelog: ICE: [`tuple_array_conversions`]: Don't expect array length to always be usize
```
tl;dr: changed [`Const::eval_target_usize`](https://github.com/rust-lang/rust/blob/master/compiler/rustc_middle/src/ty/consts.rs#L359) to [`Consts::try_eval_target_usize`](https://github.com/rust-lang/rust/blob/master/compiler/rustc_middle/src/ty/consts.rs#L327) to get rid of ICE.
I have encountered a problem with clippy: it caught ICE when working with a codebase that uses a lot of nightly features.
Here's a (stripped) ICE info:
```
error: internal compiler error: /rustc/5c6a7e71cd66705c31c9af94077901a220f0870c/compiler/rustc_middle/src/ty/consts.rs:361:32: expected usize, got Const { ty: usize, kind: N/#1 }
thread 'rustc' panicked at /rustc/5c6a7e71cd66705c31c9af94077901a220f0870c/compiler/rustc_errors/src/lib.rs:1635:9:
Box<dyn Any>
stack backtrace:
...
16: 0x110b9c590 - rustc_middle[449edf845976488d]::util::bug::bug_fmt
17: 0x102f76ae0 - clippy_lints[71754038dd04c2d2]::tuple_array_conversions::all_bindings_are_for_conv
...
```
I don't really know what's going on low-level-wise, but seems like this lin assumed that the length of the array can always be treated as `usize`, and *I assume* this doesn't play well with `feat(generic_const_exprs)`.
I wasn't able to build a minimal reproducible example, but locally this fix does resolve the issue.
Diffstat (limited to 'tests/rustdoc-js-std/parser-paths.js')
0 files changed, 0 insertions, 0 deletions
