about summary refs log tree commit diff
path: root/tests/rustdoc-ui/coverage/json.rs
diff options
context:
space:
mode:
authorNicholas Nethercote <n.nethercote@gmail.com>2022-11-18 11:24:21 +1100
committerNicholas Nethercote <n.nethercote@gmail.com>2022-11-22 09:04:15 +1100
commit48b10feedbee5b8554fa82696ce5e836933f189c (patch)
tree1725950f074be34d7a03cc7d4af8f321eff97df0 /tests/rustdoc-ui/coverage/json.rs
parent3597ed5a099488aa77caf444106a0550b7e5d2e8 (diff)
downloadrust-48b10feedbee5b8554fa82696ce5e836933f189c.tar.gz
rust-48b10feedbee5b8554fa82696ce5e836933f189c.zip
Split `MacArgs` in two.
`MacArgs` is an enum with three variants: `Empty`, `Delimited`, and `Eq`. It's
used in two ways:
- For representing attribute macro arguments (e.g. in `AttrItem`), where all
  three variants are used.
- For representing function-like macros (e.g. in `MacCall` and `MacroDef`),
  where only the `Delimited` variant is used.

In other words, `MacArgs` is used in two quite different places due to them
having partial overlap. I find this makes the code hard to read. It also leads
to various unreachable code paths, and allows invalid values (such as
accidentally using `MacArgs::Empty` in a `MacCall`).

This commit splits `MacArgs` in two:
- `DelimArgs` is a new struct just for the "delimited arguments" case. It is
  now used in `MacCall` and `MacroDef`.
- `AttrArgs` is a renaming of the old `MacArgs` enum for the attribute macro
  case. Its `Delimited` variant now contains a `DelimArgs`.

Various other related things are renamed as well.

These changes make the code clearer, avoids several unreachable paths, and
disallows the invalid values.
Diffstat (limited to 'tests/rustdoc-ui/coverage/json.rs')
0 files changed, 0 insertions, 0 deletions