diff options
| author | David Koloski <dkoloski@google.com> | 2022-09-21 13:02:37 -0400 |
|---|---|---|
| committer | David Koloski <dkoloski@google.com> | 2022-09-21 13:13:27 -0400 |
| commit | 4d015293d1cb7ebdd0972e620c3e0f1763ad2ec8 (patch) | |
| tree | e7ff35c233cbd27cdba9e66a233797c5ab2f0cd7 /tests/ui/iter_kv_map.fixed | |
| parent | 0dc24ca37640f748d0deac392cb784dd6359b96c (diff) | |
Merge commit '7248d06384c6a90de58c04c1f46be88821278d8b' into sync-from-clippy
Diffstat (limited to 'tests/ui/iter_kv_map.fixed')
| -rw-r--r-- | tests/ui/iter_kv_map.fixed | 64 |
1 files changed, 64 insertions, 0 deletions
diff --git a/tests/ui/iter_kv_map.fixed b/tests/ui/iter_kv_map.fixed new file mode 100644 index 00000000000..83fee04080f --- /dev/null +++ b/tests/ui/iter_kv_map.fixed @@ -0,0 +1,64 @@ +// run-rustfix + +#![warn(clippy::iter_kv_map)] +#![allow(clippy::redundant_clone)] +#![allow(clippy::suspicious_map)] +#![allow(clippy::map_identity)] + +use std::collections::{BTreeMap, HashMap}; + +fn main() { + let get_key = |(key, _val)| key; + + let map: HashMap<u32, u32> = HashMap::new(); + + let _ = map.keys().collect::<Vec<_>>(); + let _ = map.values().collect::<Vec<_>>(); + let _ = map.values().map(|v| v + 2).collect::<Vec<_>>(); + + let _ = map.clone().into_keys().collect::<Vec<_>>(); + let _ = map.clone().into_keys().map(|key| key + 2).collect::<Vec<_>>(); + + let _ = map.clone().into_values().collect::<Vec<_>>(); + let _ = map.clone().into_values().map(|val| val + 2).collect::<Vec<_>>(); + + let _ = map.clone().values().collect::<Vec<_>>(); + let _ = map.keys().filter(|x| *x % 2 == 0).count(); + + // Don't lint + let _ = map.iter().filter(|(_, val)| *val % 2 == 0).map(|(key, _)| key).count(); + let _ = map.iter().map(get_key).collect::<Vec<_>>(); + + // Linting the following could be an improvement to the lint + // map.iter().filter_map(|(_, val)| (val % 2 == 0).then(val * 17)).count(); + + // Lint + let _ = map.keys().map(|key| key * 9).count(); + let _ = map.values().map(|value| value * 17).count(); + + let map: BTreeMap<u32, u32> = BTreeMap::new(); + + let _ = map.keys().collect::<Vec<_>>(); + let _ = map.values().collect::<Vec<_>>(); + let _ = map.values().map(|v| v + 2).collect::<Vec<_>>(); + + let _ = map.clone().into_keys().collect::<Vec<_>>(); + let _ = map.clone().into_keys().map(|key| key + 2).collect::<Vec<_>>(); + + let _ = map.clone().into_values().collect::<Vec<_>>(); + let _ = map.clone().into_values().map(|val| val + 2).collect::<Vec<_>>(); + + let _ = map.clone().values().collect::<Vec<_>>(); + let _ = map.keys().filter(|x| *x % 2 == 0).count(); + + // Don't lint + let _ = map.iter().filter(|(_, val)| *val % 2 == 0).map(|(key, _)| key).count(); + let _ = map.iter().map(get_key).collect::<Vec<_>>(); + + // Linting the following could be an improvement to the lint + // map.iter().filter_map(|(_, val)| (val % 2 == 0).then(val * 17)).count(); + + // Lint + let _ = map.keys().map(|key| key * 9).count(); + let _ = map.values().map(|value| value * 17).count(); +} |
