diff options
| author | Michael Goulet <michael@errs.io> | 2025-03-06 15:40:05 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-03-06 15:40:05 -0500 |
| commit | 6963d74cd1ab5db912c852a2c289ca71256fab65 (patch) | |
| tree | b3c07b12908819e06fe37ca20115b4ca5a480c76 /tests/ui/patchable-function-entry/patchable-function-entry-attribute.stderr | |
| parent | d36961f2df8ed807aa5fc4e7d7aaa225cc6f7907 (diff) | |
| parent | e13af7abca71ec6aac4c2115c9563663b83c88cf (diff) | |
| download | rust-6963d74cd1ab5db912c852a2c289ca71256fab65.tar.gz rust-6963d74cd1ab5db912c852a2c289ca71256fab65.zip | |
Rollup merge of #138078 - moxian:rember-warns, r=Kobzol
Reduce the noise of bootstrap changelog warnings in --dry-run mode
Presently x.py displays "There have been changes to x.py since you last updated:" note only once when run normally, but on every invocation when run with `--dry-run`.
The disparity is not exactly intentonal, but just a historical accident.
It was made to be printed once in https://github.com/rust-lang/rust/pull/117815 via storing `.last-warned-change-id` on disk in `{config.out}/bootstrap` (i.e. `build/bootstrap`) directory.
But that didn't quite work for `--dry-run`, since `{config.out}/bootsrap` points to `build/tmp-dry-run/bootstrap` which *isn't* created in dry-run mode, so file creation fails.
This got fixed in https://github.com/rust-lang/rust/pull/118789 and now `--dry-run` does not save `.last-warned-change-id` at all. (Nor does it read it, since it cannot know to read from non-dry-run location)
This PR simply stops displaying the changelog altogether in --dry-run mode.
<details>
<summary>previous attempt (outdated)</summary>
This PR takes a different approach, and instead of not-writing the stamp in `--dry-run` mode it instead tries harder to yes-write it, and, specifically, creates `build/tmp-dry-run/bootstrap` directory to do so. If neccessary (i.e. if there are changes newer than the `change-id` stamp of config.toml to warn about).
Note that `build/tmp-dry-run/` was *already* being created, so making an extra `boostrap` sub-folder should not meaningfully pollute the build dir.
</details>
(Apologies for the, perhaps, excessively wordy PR, I'm new to this)
Diffstat (limited to 'tests/ui/patchable-function-entry/patchable-function-entry-attribute.stderr')
0 files changed, 0 insertions, 0 deletions