diff options
| author | Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> | 2023-05-05 18:40:35 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-05 18:40:35 +0530 |
| commit | ded0a9e15fdbed1110a26712b91b8ef40588bf09 (patch) | |
| tree | 9f5fb64fb1fbfa056948532c7514e3cf3591fbfe /tests/ui/rfcs/rfc-3348-c-string-literals/basic.rs | |
| parent | 65702bfd6bfb8616e182ddd19d0520ce7e35314a (diff) | |
| parent | 53647845b917fac2a1565c72f2046f6bbad341d6 (diff) | |
| download | rust-ded0a9e15fdbed1110a26712b91b8ef40588bf09.tar.gz rust-ded0a9e15fdbed1110a26712b91b8ef40588bf09.zip | |
Rollup merge of #111068 - Urgau:check-cfg-improvements, r=petrochenkov
Improve check-cfg implementation
This PR makes multiple improvements into the implementation of check-cfg, it is a prerequisite to a follow-up PR that will introduce a simpler and more explicit syntax.
The 2 main area of improvements are:
1. Internal representation of expected values:
- now uses `FxHashSet<Option<Symbol>>` instead of `FxHashSet<Symbol>`, it made the no value expected case only possible when no values where in the `HashSet` which is now represented as `None` (same as cfg represent-it).
- a enum with `Some` and `Any` makes it now clear if some values are expected or not, necessary for `feature` and `target_feature`.
2. Diagnostics: Improve the diagnostics in multiple case and fix case where a missing value could have had a new name suggestion instead of the value diagnostic; and some drive by improvements
I highly recommend reviewing commit by commit.
r? `@petrochenkov`
Diffstat (limited to 'tests/ui/rfcs/rfc-3348-c-string-literals/basic.rs')
0 files changed, 0 insertions, 0 deletions