about summary refs log tree commit diff
path: root/tests/ui
diff options
context:
space:
mode:
authorTimo <30553356+y21@users.noreply.github.com>2025-07-21 11:53:28 +0000
committerGitHub <noreply@github.com>2025-07-21 11:53:28 +0000
commitd4dea4bbe7c61311f91d408f2ba0eab3fa1d7de6 (patch)
treef6120e5215b8a1b29930666c191c3f1b7407fb78 /tests/ui
parent0b168815a46bd8132871b909405bf15f12a5438c (diff)
parent92111dcc67a4f19c6a6e8f22633b2f88f64ed6bb (diff)
downloadrust-d4dea4bbe7c61311f91d408f2ba0eab3fa1d7de6.tar.gz
rust-d4dea4bbe7c61311f91d408f2ba0eab3fa1d7de6.zip
Fix false positive in useless_attribute with redundant_imports (#15318)
Fix false positive in `useless_attribute` with `redundant_imports`

Add `redundant_imports` to the list of allowed lints on use items to
prevent
`useless_attribute` from triggering false positives when
`#[expect(redundant_imports)]`
or similar attributes are used on use statements.

fixes rust-lang/rust-clippy#15316

---

changelog: [`useless_attribute`]: fix false positive when using
`#[expect(redundant_imports)]` and similar lint attributes on `use`
statements
Diffstat (limited to 'tests/ui')
-rw-r--r--tests/ui/useless_attribute.fixed12
-rw-r--r--tests/ui/useless_attribute.rs12
2 files changed, 24 insertions, 0 deletions
diff --git a/tests/ui/useless_attribute.fixed b/tests/ui/useless_attribute.fixed
index a96c8f46f55..830aa3c976f 100644
--- a/tests/ui/useless_attribute.fixed
+++ b/tests/ui/useless_attribute.fixed
@@ -146,3 +146,15 @@ pub mod unknown_namespace {
     #[allow(rustc::non_glob_import_of_type_ir_inherent)]
     use some_module::SomeType;
 }
+
+// Regression test for https://github.com/rust-lang/rust-clippy/issues/15316
+pub mod redundant_imports_issue {
+    macro_rules! empty {
+        () => {};
+    }
+
+    #[expect(redundant_imports)]
+    pub(crate) use empty;
+
+    empty!();
+}
diff --git a/tests/ui/useless_attribute.rs b/tests/ui/useless_attribute.rs
index b26410134bb..14c69ccf2ed 100644
--- a/tests/ui/useless_attribute.rs
+++ b/tests/ui/useless_attribute.rs
@@ -146,3 +146,15 @@ pub mod unknown_namespace {
     #[allow(rustc::non_glob_import_of_type_ir_inherent)]
     use some_module::SomeType;
 }
+
+// Regression test for https://github.com/rust-lang/rust-clippy/issues/15316
+pub mod redundant_imports_issue {
+    macro_rules! empty {
+        () => {};
+    }
+
+    #[expect(redundant_imports)]
+    pub(crate) use empty;
+
+    empty!();
+}