diff options
| author | bors <bors@rust-lang.org> | 2024-01-11 09:54:22 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2024-01-11 09:54:22 +0000 |
| commit | d5366b5c19c28270dfcce4cb15c90fc7cf194a60 (patch) | |
| tree | 28a3a508762e015e0899a930869cc32ae575231a /tests | |
| parent | e4344f5fce3b4ca12d51bf27b9a0bd29297be3ea (diff) | |
| parent | 76aaf17794c37cb134fc968d04e1982958af12fd (diff) | |
| download | rust-d5366b5c19c28270dfcce4cb15c90fc7cf194a60.tar.gz rust-d5366b5c19c28270dfcce4cb15c90fc7cf194a60.zip | |
Auto merge of #16265 - Patryk27:suggest-pub-crate-imports, r=Veykril
fix: Acknowledge `pub(crate)` imports in import suggestions
rust-analyzer has logic that discounts suggesting `use`s for private imports, but that logic is unnecessarily strict - for instance given this code:
```rust
mod foo {
pub struct Foo;
}
pub(crate) use self::foo::*;
mod bar {
fn main() {
Foo$0;
}
}
```
... RA will suggest to add `use crate::foo::Foo;`, which not only makes the code overly verbose (especially in larger code bases), but also is disjoint with what rustc itself suggests.
This commit adjusts the logic, so that `pub(crate)` imports are taken into account when generating the suggestions; considering rustc's behavior, I think this change doesn't warrant any extra configuration flag.
Note that this is my first commit to RA, so I guess the approach taken here might be suboptimal - certainly feels somewhat hacky, maybe there's some better way of finding out the optimal import path 😅
Diffstat (limited to 'tests')
0 files changed, 0 insertions, 0 deletions
