diff options
| -rw-r--r-- | docs/dev/style.md | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/docs/dev/style.md b/docs/dev/style.md index 2454087e89d..44f0956c247 100644 --- a/docs/dev/style.md +++ b/docs/dev/style.md @@ -239,8 +239,9 @@ If the line is too long, you want to split the sentence in two :-) # Commit Style We don't have specific rules around git history hygiene. -Maintaining clean git history is encouraged, but not enforced. +Maintaining clean git history is strongly encouraged, but not enforced. Use rebase workflow, it's OK to rewrite history during PR review process. +After you are happy with the state of the code, please use [interactive rebase](https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History) to squash fixup commits. Avoid @mentioning people in commit messages and pull request descriptions(they are added to commit message by bors). Such messages create a lot of duplicate notification traffic during rebases. |