diff options
| -rw-r--r-- | tests/ui/useless_attribute.fixed | 49 | ||||
| -rw-r--r-- | tests/ui/useless_attribute.rs | 1 | ||||
| -rw-r--r-- | tests/ui/useless_attribute.stderr | 4 |
3 files changed, 52 insertions, 2 deletions
diff --git a/tests/ui/useless_attribute.fixed b/tests/ui/useless_attribute.fixed new file mode 100644 index 00000000000..d729311e907 --- /dev/null +++ b/tests/ui/useless_attribute.fixed @@ -0,0 +1,49 @@ +// run-rustfix +// aux-build:proc_macro_derive.rs + +#![warn(clippy::useless_attribute)] +#![warn(unreachable_pub)] + +#![allow(dead_code)] +#![cfg_attr(feature = "cargo-clippy", allow(dead_code))] +#[rustfmt::skip] +#[cfg_attr(feature = "cargo-clippy", + allow(dead_code))] +#[allow(unused_imports)] +#[allow(unused_extern_crates)] +#[macro_use] +extern crate clippy_lints; + +#[macro_use] +extern crate proc_macro_derive; + +// don't lint on unused_import for `use` items +#[allow(unused_imports)] +use std::collections; + +// don't lint on deprecated for `use` items +mod foo { + #[deprecated] + pub struct Bar; +} +#[allow(deprecated)] +pub use foo::Bar; + +// This should not trigger the lint. There's lint level definitions inside the external derive +// that would trigger the useless_attribute lint. +#[derive(DeriveSomething)] +struct Baz; + +// don't lint on unreachable_pub for `use` items +mod a { + mod b { + #[allow(dead_code)] + #[allow(unreachable_pub)] + pub struct C {} + } + + #[allow(unreachable_pub)] + pub use self::b::C; +} + +fn main() {} diff --git a/tests/ui/useless_attribute.rs b/tests/ui/useless_attribute.rs index dd84b1b2c1c..c6fc5531127 100644 --- a/tests/ui/useless_attribute.rs +++ b/tests/ui/useless_attribute.rs @@ -1,3 +1,4 @@ +// run-rustfix // aux-build:proc_macro_derive.rs #![warn(clippy::useless_attribute)] diff --git a/tests/ui/useless_attribute.stderr b/tests/ui/useless_attribute.stderr index bf7ea1698d3..87a1291543e 100644 --- a/tests/ui/useless_attribute.stderr +++ b/tests/ui/useless_attribute.stderr @@ -1,5 +1,5 @@ error: useless lint attribute - --> $DIR/useless_attribute.rs:6:1 + --> $DIR/useless_attribute.rs:7:1 | LL | #[allow(dead_code)] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` @@ -7,7 +7,7 @@ LL | #[allow(dead_code)] = note: `-D clippy::useless-attribute` implied by `-D warnings` error: useless lint attribute - --> $DIR/useless_attribute.rs:7:1 + --> $DIR/useless_attribute.rs:8:1 | LL | #[cfg_attr(feature = "cargo-clippy", allow(dead_code))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#