about summary refs log tree commit diff
diff options
context:
space:
mode:
-rw-r--r--clippy_lints/src/missing_doc.rs4
-rw-r--r--tests/ui/missing-doc-crate.rs5
-rw-r--r--tests/ui/missing-doc-crate.stderr0
3 files changed, 6 insertions, 3 deletions
diff --git a/clippy_lints/src/missing_doc.rs b/clippy_lints/src/missing_doc.rs
index 5c3fa68620c..f5dab6d1fed 100644
--- a/clippy_lints/src/missing_doc.rs
+++ b/clippy_lints/src/missing_doc.rs
@@ -53,16 +53,14 @@ impl MissingDoc {
         *self.doc_hidden_stack.last().expect("empty doc_hidden_stack")
     }
 
-    #[allow(clippy::needless_bool)]
     fn has_include(meta: Option<MetaItem>) -> bool {
         if_chain! {
             if let Some(meta) = meta;
             if let MetaItemKind::List(list) = meta.node;
             if let Some(meta) = list.get(0);
             if let Some(name) = meta.name();
-            if name == "include";
             then {
-                true
+                name == "include"
             } else {
                 false
             }
diff --git a/tests/ui/missing-doc-crate.rs b/tests/ui/missing-doc-crate.rs
new file mode 100644
index 00000000000..04711f86488
--- /dev/null
+++ b/tests/ui/missing-doc-crate.rs
@@ -0,0 +1,5 @@
+#![warn(clippy::missing_docs_in_private_items)]
+#![feature(external_doc)]
+#![doc(include = "../../README.md")]
+
+fn main() {}
diff --git a/tests/ui/missing-doc-crate.stderr b/tests/ui/missing-doc-crate.stderr
new file mode 100644
index 00000000000..e69de29bb2d
--- /dev/null
+++ b/tests/ui/missing-doc-crate.stderr