diff options
Diffstat (limited to 'src/libstd')
| -rw-r--r-- | src/libstd/arc.rs | 9 | ||||
| -rw-r--r-- | src/libstd/getopts.rs | 14 | ||||
| -rw-r--r-- | src/libstd/json.rs | 6 | ||||
| -rw-r--r-- | src/libstd/map.rs | 21 | ||||
| -rw-r--r-- | src/libstd/net_ip.rs | 4 | ||||
| -rw-r--r-- | src/libstd/serialization.rs | 2 | ||||
| -rw-r--r-- | src/libstd/sha1.rs | 8 | ||||
| -rw-r--r-- | src/libstd/smallintmap.rs | 14 | ||||
| -rw-r--r-- | src/libstd/sort.rs | 2 | ||||
| -rw-r--r-- | src/libstd/term.rs | 2 | ||||
| -rw-r--r-- | src/libstd/test.rs | 46 | ||||
| -rw-r--r-- | src/libstd/time.rs | 24 |
12 files changed, 83 insertions, 69 deletions
diff --git a/src/libstd/arc.rs b/src/libstd/arc.rs index a50e897358c..5c4e1097fe2 100644 --- a/src/libstd/arc.rs +++ b/src/libstd/arc.rs @@ -642,6 +642,7 @@ mod tests { c.send(()); } } + // Readers try to catch the writer in the act let mut children = ~[]; for 5.times { @@ -652,8 +653,10 @@ mod tests { } } } + // Wait for children to pass their asserts - for vec::each(children) |r| { future::get(&r); } + for vec::each(children) |r| { future::get(r); } + // Wait for writer to finish p.recv(); do arc.read |num| { assert *num == 10; } @@ -714,7 +717,7 @@ mod tests { *state = 31337; // send to other readers for vec::each(reader_convos) |x| { - match x { + match *x { (rc, _) => rc.send(()), } } @@ -723,7 +726,7 @@ mod tests { do (&read_mode).read |state| { // complete handshake with other readers for vec::each(reader_convos) |x| { - match x { + match *x { (_, rp) => rp.recv(), } } diff --git a/src/libstd/getopts.rs b/src/libstd/getopts.rs index 36492834c2a..67d3619b0e2 100644 --- a/src/libstd/getopts.rs +++ b/src/libstd/getopts.rs @@ -294,14 +294,14 @@ fn getopts(args: &[~str], opts: &[Opt]) -> Result unsafe { let mut name_pos = 0u; for vec::each(names) |nm| { name_pos += 1u; - let optid = match find_opt(opts, nm) { + let optid = match find_opt(opts, *nm) { Some(id) => id, - None => return Err(UnrecognizedOption(name_str(&nm))) + None => return Err(UnrecognizedOption(name_str(nm))) }; match opts[optid].hasarg { No => { if !option::is_none::<~str>(i_arg) { - return Err(UnexpectedArgument(name_str(&nm))); + return Err(UnexpectedArgument(name_str(nm))); } vec::push(vals[optid], Given); } @@ -318,7 +318,7 @@ fn getopts(args: &[~str], opts: &[Opt]) -> Result unsafe { vec::push(vals[optid], Val(option::get::<~str>(i_arg))); } else if i + 1u == l { - return Err(ArgumentMissing(name_str(&nm))); + return Err(ArgumentMissing(name_str(nm))); } else { i += 1u; vec::push(vals[optid], Val(args[i])); } } } @@ -367,7 +367,7 @@ fn opt_present(+mm: Matches, nm: &str) -> bool { /// Returns true if any of several options were matched fn opts_present(+mm: Matches, names: &[~str]) -> bool { for vec::each(names) |nm| { - match find_opt(mm.opts, mkname(nm)) { + match find_opt(mm.opts, mkname(*nm)) { Some(_) => return true, None => () } @@ -394,7 +394,7 @@ fn opt_str(+mm: Matches, nm: &str) -> ~str { */ fn opts_str(+mm: Matches, names: &[~str]) -> ~str { for vec::each(names) |nm| { - match opt_val(mm, nm) { + match opt_val(mm, *nm) { Val(s) => return s, _ => () } @@ -412,7 +412,7 @@ fn opts_str(+mm: Matches, names: &[~str]) -> ~str { fn opt_strs(+mm: Matches, nm: &str) -> ~[~str] { let mut acc: ~[~str] = ~[]; for vec::each(opt_vals(mm, nm)) |v| { - match v { Val(s) => vec::push(acc, s), _ => () } + match *v { Val(s) => vec::push(acc, s), _ => () } } return acc; } diff --git a/src/libstd/json.rs b/src/libstd/json.rs index b269ca84104..5b7c92f59fa 100644 --- a/src/libstd/json.rs +++ b/src/libstd/json.rs @@ -179,7 +179,7 @@ fn to_writer_pretty(wr: io::Writer, j: Json, indent: uint) { fn escape_str(s: &str) -> ~str { let mut escaped = ~"\""; - do str::chars_iter(s) |c| { + for str::chars_each(s) |c| { match c { '"' => escaped += ~"\\\"", '\\' => escaped += ~"\\\\", @@ -834,8 +834,8 @@ mod tests { fn mk_dict(items: &[(~str, Json)]) -> Json { let d = map::str_hash(); - do vec::iter(items) |item| { - let (key, value) = copy item; + for vec::each(items) |item| { + let (key, value) = copy *item; d.insert(key, value); }; diff --git a/src/libstd/map.rs b/src/libstd/map.rs index 1726e1f581f..7d609a42ebd 100644 --- a/src/libstd/map.rs +++ b/src/libstd/map.rs @@ -435,9 +435,12 @@ fn vec_from_set<T:Eq IterBytes Hash Copy>(s: Set<T>) -> ~[T] { fn hash_from_vec<K: Eq IterBytes Hash Const Copy, V: Copy>( items: &[(K, V)]) -> HashMap<K, V> { let map = HashMap(); - do vec::iter(items) |item| { - let (key, value) = item; - map.insert(key, value); + for vec::each(items) |item| { + match *item { + (key, value) => { + map.insert(key, value); + } + } } map } @@ -520,7 +523,7 @@ impl<K: Eq IterBytes Hash Copy, V: Copy> @Mut<LinearMap<K, V>>: pure fn each(op: fn(+key: K, +value: V) -> bool) { unsafe { do self.borrow_imm |p| { - p.each(op) + p.each(|k, v| op(*k, *v)) } } } @@ -528,7 +531,7 @@ impl<K: Eq IterBytes Hash Copy, V: Copy> @Mut<LinearMap<K, V>>: pure fn each_key(op: fn(+key: K) -> bool) { unsafe { do self.borrow_imm |p| { - p.each_key(op) + p.each_key(|k| op(*k)) } } } @@ -536,7 +539,7 @@ impl<K: Eq IterBytes Hash Copy, V: Copy> @Mut<LinearMap<K, V>>: pure fn each_value(op: fn(+value: V) -> bool) { unsafe { do self.borrow_imm |p| { - p.each_value(op) + p.each_value(|v| op(*v)) } } } @@ -544,7 +547,7 @@ impl<K: Eq IterBytes Hash Copy, V: Copy> @Mut<LinearMap<K, V>>: pure fn each_ref(op: fn(key: &K, value: &V) -> bool) { unsafe { do self.borrow_imm |p| { - p.each_ref(op) + p.each(op) } } } @@ -552,7 +555,7 @@ impl<K: Eq IterBytes Hash Copy, V: Copy> @Mut<LinearMap<K, V>>: pure fn each_key_ref(op: fn(key: &K) -> bool) { unsafe { do self.borrow_imm |p| { - p.each_key_ref(op) + p.each_key(op) } } } @@ -560,7 +563,7 @@ impl<K: Eq IterBytes Hash Copy, V: Copy> @Mut<LinearMap<K, V>>: pure fn each_value_ref(op: fn(value: &V) -> bool) { unsafe { do self.borrow_imm |p| { - p.each_value_ref(op) + p.each_value(op) } } } diff --git a/src/libstd/net_ip.rs b/src/libstd/net_ip.rs index 4e23e3a1592..c840d320375 100644 --- a/src/libstd/net_ip.rs +++ b/src/libstd/net_ip.rs @@ -364,12 +364,12 @@ mod test { log(debug, fmt!("test_get_addr: Number of results for %s: %?", localhost_name, vec::len(results))); for vec::each(results) |r| { - let ipv_prefix = match r { + let ipv_prefix = match *r { Ipv4(_) => ~"IPv4", Ipv6(_) => ~"IPv6" }; log(debug, fmt!("test_get_addr: result %s: '%s'", - ipv_prefix, format_addr(&r))); + ipv_prefix, format_addr(r))); } // at least one result.. this is going to vary from system // to system, based on stuff like the contents of /etc/hosts diff --git a/src/libstd/serialization.rs b/src/libstd/serialization.rs index 64254d5b2e5..72b3c747e35 100644 --- a/src/libstd/serialization.rs +++ b/src/libstd/serialization.rs @@ -91,7 +91,7 @@ trait Deserializer { fn emit_from_vec<S: Serializer, T>(s: S, v: ~[T], f: fn(T)) { do s.emit_vec(vec::len(v)) { - do vec::iteri(v) |i,e| { + for vec::eachi(v) |i,e| { do s.emit_vec_elt(i) { f(e) } diff --git a/src/libstd/sha1.rs b/src/libstd/sha1.rs index 9808b15dc66..c16e29f2770 100644 --- a/src/libstd/sha1.rs +++ b/src/libstd/sha1.rs @@ -66,7 +66,7 @@ fn sha1() -> Sha1 { fn add_input(st: &Sha1State, msg: &[u8]) { assert (!st.computed); for vec::each(msg) |element| { - st.msg_block[st.msg_block_idx] = element; + st.msg_block[st.msg_block_idx] = *element; st.msg_block_idx += 1u; st.len_low += 8u32; if st.len_low == 0u32 { @@ -161,7 +161,7 @@ fn sha1() -> Sha1 { fn mk_result(st: &Sha1State) -> ~[u8] { if !(*st).computed { pad_msg(st); (*st).computed = true; } let mut rs: ~[u8] = ~[]; - for vec::each_mut_ref((*st).h) |ptr_hpart| { + for vec::each_mut((*st).h) |ptr_hpart| { let hpart = *ptr_hpart; let a = (hpart >> 24u32 & 0xFFu32) as u8; let b = (hpart >> 16u32 & 0xFFu32) as u8; @@ -240,7 +240,9 @@ fn sha1() -> Sha1 { fn result_str() -> ~str { let rr = mk_result(&self); let mut s = ~""; - for vec::each(rr) |b| { s += uint::to_str(b as uint, 16u); } + for vec::each(rr) |b| { + s += uint::to_str(*b as uint, 16u); + } return s; } } diff --git a/src/libstd/smallintmap.rs b/src/libstd/smallintmap.rs index ab4d46d2d8b..5366774db37 100644 --- a/src/libstd/smallintmap.rs +++ b/src/libstd/smallintmap.rs @@ -103,21 +103,15 @@ impl<V: Copy> SmallIntMap<V>: map::Map<uint, V> { fn get(+key: uint) -> V { get(self, key) } pure fn find(+key: uint) -> Option<V> { find(self, key) } fn rehash() { fail } + pure fn each(it: fn(+key: uint, +value: V) -> bool) { - let mut idx = 0u, l = self.v.len(); - while idx < l { - match self.v.get_elt(idx) { - Some(elt) => if !it(idx, elt) { break }, - None => () - } - idx += 1u; - } + self.each_ref(|k, v| it(*k, *v)) } pure fn each_key(it: fn(+key: uint) -> bool) { - self.each(|k, _v| it(k)) + self.each_ref(|k, _v| it(*k)) } pure fn each_value(it: fn(+value: V) -> bool) { - self.each(|_k, v| it(v)) + self.each_ref(|_k, v| it(*v)) } pure fn each_ref(it: fn(key: &uint, value: &V) -> bool) { let mut idx = 0u, l = self.v.len(); diff --git a/src/libstd/sort.rs b/src/libstd/sort.rs index 74ee337f5b5..c32f7413a92 100644 --- a/src/libstd/sort.rs +++ b/src/libstd/sort.rs @@ -260,7 +260,7 @@ mod test_qsort { let pairs = vec::zip(expected, immut_names); for vec::each(pairs) |p| { - let (a, b) = p; + let (a, b) = *p; debug!("%d %d", a, b); assert (a == b); } diff --git a/src/libstd/term.rs b/src/libstd/term.rs index 34244e95c0c..6a264161bc7 100644 --- a/src/libstd/term.rs +++ b/src/libstd/term.rs @@ -40,7 +40,7 @@ fn color_supported() -> bool { return match os::getenv(~"TERM") { option::Some(env) => { for vec::each(supported_terms) |term| { - if term == env { return true; } + if *term == env { return true; } } false } diff --git a/src/libstd/test.rs b/src/libstd/test.rs index 76b6310c853..8692a9a440a 100644 --- a/src/libstd/test.rs +++ b/src/libstd/test.rs @@ -227,7 +227,7 @@ fn print_failures(st: ConsoleTestState) { let failures = vec::map(failures, |test| test.name); let failures = sort::merge_sort(|x, y| str::le(*x, *y), failures); for vec::each(failures) |name| { - st.out.write_line(fmt!(" %s", name)); + st.out.write_line(fmt!(" %s", *name)); } } @@ -535,30 +535,34 @@ mod tests { ~"test::sort_tests"]; let tests = { - let testfn = fn~() { }; - let mut tests = ~[]; + let testfn = fn~() { }; + let mut tests = ~[]; for vec::each(names) |name| { - let test = {name: name, testfn: copy testfn, ignore: false, - should_fail: false}; - tests += ~[test]; - } - tests - }; - let filtered = filter_tests(opts, tests); + let test = {name: *name, testfn: copy testfn, ignore: false, + should_fail: false}; + vec::push(tests, test); + } + tests + }; + let filtered = filter_tests(opts, tests); - let expected = - ~[~"int::test_pow", ~"int::test_to_str", ~"sha1::test", - ~"test::do_not_run_ignored_tests", - ~"test::filter_for_ignored_option", - ~"test::first_free_arg_should_be_a_filter", - ~"test::ignored_tests_result_in_ignored", - ~"test::parse_ignored_flag", - ~"test::sort_tests"]; + let expected = + ~[~"int::test_pow", ~"int::test_to_str", ~"sha1::test", + ~"test::do_not_run_ignored_tests", + ~"test::filter_for_ignored_option", + ~"test::first_free_arg_should_be_a_filter", + ~"test::ignored_tests_result_in_ignored", + ~"test::parse_ignored_flag", + ~"test::sort_tests"]; - let pairs = vec::zip(expected, filtered); + let pairs = vec::zip(expected, filtered); - for vec::each(pairs) |p| { let (a, b) = copy p; assert (a == b.name); } -} + for vec::each(pairs) |p| { + match *p { + (a, b) => { assert (a == b.name); } + } + } + } } diff --git a/src/libstd/time.rs b/src/libstd/time.rs index 84d4e49ef90..45ea25c3858 100644 --- a/src/libstd/time.rs +++ b/src/libstd/time.rs @@ -1023,7 +1023,7 @@ mod tests { } } - [ + for vec::each([ ~"Sunday", ~"Monday", ~"Tuesday", @@ -1031,9 +1031,11 @@ mod tests { ~"Thursday", ~"Friday", ~"Saturday" - ]/_.iter(|day| assert test(day, ~"%A")); + ]) |day| { + assert test(*day, ~"%A"); + } - [ + for vec::each([ ~"Sun", ~"Mon", ~"Tue", @@ -1041,9 +1043,11 @@ mod tests { ~"Thu", ~"Fri", ~"Sat" - ]/_.iter(|day| assert test(day, ~"%a")); + ]) |day| { + assert test(*day, ~"%a"); + } - [ + for vec::each([ ~"January", ~"February", ~"March", @@ -1056,9 +1060,11 @@ mod tests { ~"October", ~"November", ~"December" - ]/_.iter(|day| assert test(day, ~"%B")); + ]) |day| { + assert test(*day, ~"%B"); + } - [ + for vec::each([ ~"Jan", ~"Feb", ~"Mar", @@ -1071,7 +1077,9 @@ mod tests { ~"Oct", ~"Nov", ~"Dec" - ]/_.iter(|day| assert test(day, ~"%b")); + ]) |day| { + assert test(*day, ~"%b"); + } assert test(~"19", ~"%C"); assert test(~"Fri Feb 13 23:31:30 2009", ~"%c"); |
