diff options
Diffstat (limited to 'src/libstd')
| -rw-r--r-- | src/libstd/process.rs | 13 | ||||
| -rw-r--r-- | src/libstd/rt/mod.rs | 2 | ||||
| -rw-r--r-- | src/libstd/rt/util.rs | 32 |
3 files changed, 3 insertions, 44 deletions
diff --git a/src/libstd/process.rs b/src/libstd/process.rs index 3471805b2bc..269a1638b0a 100644 --- a/src/libstd/process.rs +++ b/src/libstd/process.rs @@ -591,7 +591,6 @@ mod tests { use io::prelude::*; use io::ErrorKind; - use rt::running_on_valgrind; use str; use super::{Command, Output, Stdio}; @@ -737,10 +736,7 @@ mod tests { assert!(status.success()); assert_eq!(output_str.trim().to_string(), "hello"); - // FIXME #7224 - if !running_on_valgrind() { - assert_eq!(stderr, Vec::new()); - } + assert_eq!(stderr, Vec::new()); } #[cfg(not(target_os="android"))] @@ -779,10 +775,7 @@ mod tests { assert!(status.success()); assert_eq!(output_str.trim().to_string(), "hello"); - // FIXME #7224 - if !running_on_valgrind() { - assert_eq!(stderr, Vec::new()); - } + assert_eq!(stderr, Vec::new()); } #[cfg(all(unix, not(target_os="android")))] @@ -807,7 +800,6 @@ mod tests { #[test] fn test_inherit_env() { use std::env; - if running_on_valgrind() { return; } let result = env_cmd().output().unwrap(); let output = String::from_utf8(result.stdout).unwrap(); @@ -824,7 +816,6 @@ mod tests { #[test] fn test_inherit_env() { use std::env; - if running_on_valgrind() { return; } let mut result = env_cmd().output().unwrap(); let output = String::from_utf8(result.stdout).unwrap(); diff --git a/src/libstd/rt/mod.rs b/src/libstd/rt/mod.rs index 0ac0d03e19d..7e86bb775a1 100644 --- a/src/libstd/rt/mod.rs +++ b/src/libstd/rt/mod.rs @@ -26,7 +26,7 @@ use sys; use usize; // Reexport some of our utilities which are expected by other crates. -pub use self::util::{min_stack, running_on_valgrind}; +pub use self::util::min_stack; pub use self::unwind::{begin_unwind, begin_unwind_fmt}; // Reexport some functionality from liballoc. diff --git a/src/libstd/rt/util.rs b/src/libstd/rt/util.rs index 031fda089c8..0fe8d873a75 100644 --- a/src/libstd/rt/util.rs +++ b/src/libstd/rt/util.rs @@ -16,38 +16,6 @@ use intrinsics; use sync::atomic::{self, Ordering}; use sys::stdio::Stderr; -/// Dynamically inquire about whether we're running under V. -/// You should usually not use this unless your test definitely -/// can't run correctly un-altered. Valgrind is there to help -/// you notice weirdness in normal, un-doctored code paths! -pub fn running_on_valgrind() -> bool { - return on_valgrind(); - #[cfg(windows)] - fn on_valgrind() -> bool { false } - - #[cfg(unix)] - fn on_valgrind() -> bool { - use libc::uintptr_t; - extern { - fn rust_running_on_valgrind() -> uintptr_t; - } - unsafe { rust_running_on_valgrind() != 0 } - } -} - -/// Valgrind has a fixed-sized array (size around 2000) of segment descriptors -/// wired into it; this is a hard limit and requires rebuilding valgrind if you -/// want to go beyond it. Normally this is not a problem, but in some tests, we -/// produce a lot of threads casually. Making lots of threads alone might not -/// be a problem _either_, except on OSX, the segments produced for new threads -/// _take a while_ to get reclaimed by the OS. Combined with the fact that libuv -/// schedulers fork off a separate thread for polling fsevents on OSX, we get a -/// perfect storm of creating "too many mappings" for valgrind to handle when -/// running certain stress tests in the runtime. -pub fn limit_thread_creation_due_to_osx_and_valgrind() -> bool { - (cfg!(target_os="macos")) && running_on_valgrind() -} - pub fn min_stack() -> usize { static MIN: atomic::AtomicUsize = atomic::AtomicUsize::new(0); match MIN.load(Ordering::SeqCst) { |
