| Age | Commit message (Collapse) | Author | Lines |
|---|
|
Rollup of 3 pull requests
Successful merges:
- #115476 (document ABI compatibility)
- #117688 (Misc changes to StableMIR required to Kani use case.)
- #117998 (On resolve error of `[rest..]`, suggest `[rest @ ..]`)
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
On resolve error of `[rest..]`, suggest `[rest @ ..]`
When writing a pattern to collect multiple entries of a slice in a single binding, it is easy to misremember or typo the appropriate syntax to do so, instead writing the experimental `X..` pattern syntax. When we encounter a resolve error because `X` isn't available, we suggest `X @ ..` as an alternative.
```
error[E0425]: cannot find value `rest` in this scope
--> $DIR/range-pattern-meant-to-be-slice-rest-pattern.rs:3:13
|
LL | [1, rest..] => println!("{rest:?}"),
| ^^^^ not found in this scope
|
help: if you meant to collect the rest of the slice in `rest`, use the at operator
|
LL | [1, rest @ ..] => println!("{rest:?}"),
| +
```
Fix #88404.
|
|
Misc changes to StableMIR required to Kani use case.
First, I wanted to say that I can split this review into multiple if it makes reviewing easier. I bundled them up, since I've been testing them together (See https://github.com/rust-lang/project-stable-mir/pull/51 for the set of more thorough checks).
So far, this review includes 3 commits:
1. Add more APIs and fix `Instance::body`
- Add more APIs to retrieve information about types.
- Add a few more instance resolution options. For the drop shim, we return None if the drop body is empty. Not sure it will be enough.
- Make `Instance::body()` return an Option<Body>, since not every instance might have an available body. For example, foreign instances, virtual instances, dependencies.
2. Fix a bug on MIRVisitor
- We were not iterating over all local variables due to a typo.
3. Add more SMIR internal impl and callback return value
- In cases like Kani, we will invoke the rustc_internal run command directly for now. It would be handly to be able to have a callback that can return a value.
- We also need extra methods to convert stable constructs into internal ones, so we can break down the transition into finer grain commits.
- For the internal implementation of Region, we're always returning `ReErased` for now.
|
|
document ABI compatibility
I don't think we have any central place where we document our ABI compatibility rules, so let's create one. The `fn()` pointer type seems like a good place since ABI questions can only become relevant when invoking a function through a function pointer.
This will likely need T-lang FCP.
|
|
|
|
Subtree update of `rust-analyzer`
r? `@ghost`
Out of band, but required for https://github.com/rust-lang/rust/pull/117981.
|
|
Rollup of 5 pull requests
Successful merges:
- #117649 (Move `lint_store`)
- #117850 (bootstrap: simplify setting unstable-options for tools)
- #117889 (docs(release): Clarify cargo entries)
- #117946 (avoid exhaustive i16 test in Miri)
- #117963 (`rustc_query_system` cleanups)
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
`rustc_query_system` cleanups
Minor cleanups.
r? `@compiler-errors`
|
|
avoid exhaustive i16 test in Miri
https://github.com/rust-lang/rust/pull/116301 added a test that is way too slow to be running in Miri. So let's only test a few hopefully representative cases.
|
|
docs(release): Clarify cargo entries
Trying to make these easier to scan and more understandable out of the context of their PR
|
|
bootstrap: simplify setting unstable-options for tools
Previously, we unconditionally(instead of `if path == "src/tools/clippy" || ..`) set this (to prevent recompiling tools between `x check $tool` and '` check $another_tool` executions) specifically for tools in the `x check` step. This PR relocates that logic to `fn prepare_tool_cargo`, making it step-agnostic.
Fixes #116538
Fixes #117983
|
|
Move `lint_store`
Some nice cleanups enabled by the removal of compiler plugins.
r? `@cjgillot`
|
|
Subtree sync for rustc_codegen_cranelift
The main highlights this time are support for AES and SHA256 crypto intrinsics on x86_64 by lowering to inline asm.
r? `@ghost`
`@rustbot` label +A-codegen +A-cranelift +T-compiler
|
|
When writing a pattern to collect multiple entries of a slice in a
single binding, it is easy to misremember or typo the appropriate syntax
to do so, instead writing the experimental `X..` pattern syntax. When we
encounter a resolve error because `X` isn't available, we suggest
`X @ ..` as an alternative.
```
error[E0425]: cannot find value `rest` in this scope
--> $DIR/range-pattern-meant-to-be-slice-rest-pattern.rs:3:13
|
LL | [1, rest..] => println!("{rest:?}"),
| ^^^^ not found in this scope
|
help: if you meant to collect the rest of the slice in `rest`, use the at operator
|
LL | [1, rest @ ..] => println!("{rest:?}"),
| +
```
Fix #88404.
|
|
Rollup of 5 pull requests
Successful merges:
- #117892 (Detect more `=>` typos)
- #117959 (Better handle type errors involving `Self` literals)
- #117980 (fix: Update CONTRIBUTING.md recommend -> recommended)
- #117982 (bootstrap: only show PGO warnings when verbose)
- #117990 (Tweak error and move tests)
Failed merges:
- #117944 (some additional region refactorings)
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
Tweak error and move tests
r? `@Nilstrieb`
Split off #117565.
|
|
bootstrap: only show PGO warnings when verbose
Building rustc with `--rust-profile-use` is currently dumping a lot of
warnings of "no profile data available for function" from `rustc_smir`
and `stable_mir`. These simply aren't exercised by the current profile-
gathering steps, but that's to be expected for new or experimental
functionality. I think for most people, these warnings will be just
noise, so it makes sense to only have them in verbose builds.
|
|
fix: Update CONTRIBUTING.md recommend -> recommended
Redo of https://github.com/rust-lang/rust/pull/116529.
|
|
Better handle type errors involving `Self` literals
When encountering a type error involving a `Self` literal, point at the self type of the enclosing `impl` and suggest using the actual type name instead.
```
error[E0308]: mismatched types
--> $DIR/struct-path-self-type-mismatch.rs:13:9
|
LL | impl<T> Foo<T> {
| - ------ this is the type of the `Self` literal
| |
| found type parameter
LL | fn new<U>(u: U) -> Foo<U> {
| - ------ expected `Foo<U>` because of return type
| |
| expected type parameter
LL | / Self {
LL | |
LL | | inner: u
LL | |
LL | | }
| |_________^ expected `Foo<U>`, found `Foo<T>`
|
= note: expected struct `Foo<U>`
found struct `Foo<T>`
= note: a type parameter was expected, but a different one was found; you might be missing a type parameter or trait bound
= note: for more information, visit https://doc.rust-lang.org/book/ch10-02-traits.html#traits-as-parameters
help: use the type name directly
|
LL | Foo::<U> {
| ~~~~~~~~
```
Fix #76086.
|
|
Detect more `=>` typos
Handle and recover `match expr { pat >= { arm } }`.
|
|
Lint registration now happens early enough that we can run it from
`Config`, before `Compiler` is created.
|
|
This was made possible by the removal of plugin support, which
simplified lint store creation.
This simplifies the places in rustc and rustdoc that call
`describe_lints`, which are early on. The lint store is now built before
those places, so they don't have to create their own lint store for
temporary use, they can just use the main one.
|
|
|
|
|
|
|
|
|
|
sync_cg_clif-2023-11-16
|
|
Clippy subtree sync
r? `@Manishearth`
|
|
|
|
|
|
|
|
Fixed the `has_body()` function operator. Before that, this function was
returning false for all shims.
Change resolve_drop_in_place() to also return an instance for empty
shims, since they may still be required for vtable construction.
|
|
We were previously skipping it for non-generic functions, but this was
leaving some constants unevaluated.
|
|
|
|
Add more APIs to retrieve information about types, and add more instance
resolution options.
Make `Instance::body()` return an Option<Body>, since not every instance
might have an available body. For example, foreign instances, virtual
instances, dependencies.
|
|
internal: Bump libc
CC https://github.com/rust-lang/rust/pull/117981
|
|
|
|
r=compiler-errors
Try to use approximate placeholder regions when outputting an AscribeUserType error in borrowck
Fixes #114866
Hi from GOSIM :)
|
|
We were not iterating over all local variables due to a typo.
|
|
In cases like Kani, we will invoke the rustc_internal run command
directly for now. It would be handly to be able to have a callback
that can return a value.
We also need extra methods to convert stable constructs into internal
ones, so we can break down the transition into finer grain commits.
|
|
Building rustc with `--rust-profile-use` is currently dumping a lot of
warnings of "no profile data available for function" from `rustc_smir`
and `stable_mir`. These simply aren't exercised by the current profile-
gathering steps, but that's to be expected for new or experimental
functionality. I think for most people, these warnings will be just
noise, so it makes sense to only have them in verbose builds.
|
|
|
|
|
|
|
|
Rustup
r? `@ghost`
changelog: none
|
|
|
|
|
|
|
|
davidbarsky:davidbarsky/allow-companion-extension-to-call-rust-analyzer, r=davidbarsky
code: expose workspaces to other extensions; remove `addProject` command
This (mostly red) PR does three things:
- Exposes two methods to companion extensions (`setWorkspaces` and `notifyRustAnalyzer`).
- `setWorkspaces` is needed to update `linkedProjects` _without_ writing workspace/global configuration.
- `notifyRustAnalyzer` to get the server to pull the new configuration.
- Makes `Ctx` implement `RustAnalyzerExtensionApi` to prevent accidental regressions.
- Remove `rust-analyzer.addProject`, as that will live in a buck2 companion extension. No need for that to be in rust-analyzer!
I can see the utility of combining `notifyRustAnalyzer` and `setWorkspaces` into a single method (`updateWorkspacesAndNotify()`?), but I don't feel strongly about this. My feeling is that this API could be easily changed in the future.
|
|
|
