1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
|
const THREE_BITS: i64 = 7;
const EVEN_MORE_REDIRECTION: i64 = THREE_BITS;
#[warn(clippy::bad_bit_mask)]
#[allow(
clippy::ineffective_bit_mask,
clippy::identity_op,
clippy::no_effect,
clippy::unnecessary_operation
)]
fn main() {
let x = 5;
x & 0 == 0;
//~^ bad_bit_mask
//~| erasing_op
x & 1 == 1; //ok, distinguishes bit 0
x & 1 == 0; //ok, compared with zero
x & 2 == 1;
//~^ bad_bit_mask
x | 0 == 0; //ok, equals x == 0 (maybe warn?)
x | 1 == 3; //ok, equals x == 2 || x == 3
x | 3 == 3; //ok, equals x <= 3
x | 3 == 2;
//~^ bad_bit_mask
x & 1 > 1;
//~^ bad_bit_mask
x & 2 > 1; // ok, distinguishes x & 2 == 2 from x & 2 == 0
x & 2 < 1; // ok, distinguishes x & 2 == 2 from x & 2 == 0
x | 1 > 1; // ok (if a bit silly), equals x > 1
x | 2 > 1;
//~^ bad_bit_mask
x | 2 <= 2; // ok (if a bit silly), equals x <= 2
x & 192 == 128; // ok, tests for bit 7 and not bit 6
x & 0xffc0 == 0xfe80; // ok
// this also now works with constants
x & THREE_BITS == 8;
//~^ bad_bit_mask
x | EVEN_MORE_REDIRECTION < 7;
//~^ bad_bit_mask
0 & x == 0;
//~^ bad_bit_mask
//~| erasing_op
1 | x > 1;
// and should now also match uncommon usage
1 < 2 | x;
//~^ bad_bit_mask
2 == 3 | x;
//~^ bad_bit_mask
1 == x & 2;
//~^ bad_bit_mask
x | 1 > 2; // no error, because we allowed ineffective bit masks
ineffective();
}
#[warn(clippy::ineffective_bit_mask)]
#[allow(clippy::bad_bit_mask, clippy::no_effect, clippy::unnecessary_operation)]
fn ineffective() {
let x = 5;
x | 1 > 3;
//~^ ineffective_bit_mask
x | 1 < 4;
//~^ ineffective_bit_mask
x | 1 <= 3;
//~^ ineffective_bit_mask
x | 1 >= 8;
//~^ ineffective_bit_mask
x | 1 > 2; // not an error (yet), better written as x >= 2
x | 1 >= 7; // not an error (yet), better written as x >= 6
x | 3 > 4; // not an error (yet), better written as x >= 4
x | 4 <= 19;
}
|
