blob: 1b1108d6ce5043afc03e803dbb5dc1766c7fb770 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
|
#![allow(non_local_definitions, clippy::needless_if)]
#![warn(clippy::bool_comparison)]
#![allow(clippy::non_canonical_partial_ord_impl)]
fn main() {
let x = true;
let _ = if x == true { "yes" } else { "no" };
//~^ bool_comparison
let _ = if x == false { "yes" } else { "no" };
//~^ bool_comparison
let _ = if true == x { "yes" } else { "no" };
//~^ bool_comparison
let _ = if false == x { "yes" } else { "no" };
//~^ bool_comparison
let _ = if x != true { "yes" } else { "no" };
//~^ bool_comparison
let _ = if x != false { "yes" } else { "no" };
//~^ bool_comparison
let _ = if true != x { "yes" } else { "no" };
//~^ bool_comparison
let _ = if false != x { "yes" } else { "no" };
//~^ bool_comparison
let _ = if x < true { "yes" } else { "no" };
//~^ bool_comparison
let _ = if false < x { "yes" } else { "no" };
//~^ bool_comparison
let _ = if x > false { "yes" } else { "no" };
//~^ bool_comparison
let _ = if true > x { "yes" } else { "no" };
//~^ bool_comparison
let y = true;
let _ = if x < y { "yes" } else { "no" };
//~^ bool_comparison
let _ = if x > y { "yes" } else { "no" };
//~^ bool_comparison
}
fn issue3703() {
struct Foo;
impl PartialEq<bool> for Foo {
fn eq(&self, _: &bool) -> bool {
true
}
}
impl PartialEq<Foo> for bool {
fn eq(&self, _: &Foo) -> bool {
true
}
}
impl PartialOrd<bool> for Foo {
fn partial_cmp(&self, _: &bool) -> Option<std::cmp::Ordering> {
None
}
}
impl PartialOrd<Foo> for bool {
fn partial_cmp(&self, _: &Foo) -> Option<std::cmp::Ordering> {
None
}
}
if Foo == true {}
if true == Foo {}
if Foo != true {}
if true != Foo {}
if Foo == false {}
if false == Foo {}
if Foo != false {}
if false != Foo {}
if Foo < false {}
if false < Foo {}
}
macro_rules! m {
($func:ident) => {
$func()
};
}
fn func() -> bool {
true
}
fn issue3973() {
// ok, don't lint on `cfg` invocation
if false == cfg!(feature = "debugging") {}
if cfg!(feature = "debugging") == false {}
if true == cfg!(feature = "debugging") {}
if cfg!(feature = "debugging") == true {}
// lint, could be simplified
if false == m!(func) {}
//~^ bool_comparison
if m!(func) == false {}
//~^ bool_comparison
if true == m!(func) {}
//~^ bool_comparison
if m!(func) == true {}
//~^ bool_comparison
// no lint with a variable
let is_debug = false;
if is_debug == cfg!(feature = "debugging") {}
if cfg!(feature = "debugging") == is_debug {}
if is_debug == m!(func) {}
if m!(func) == is_debug {}
let is_debug = true;
if is_debug == cfg!(feature = "debugging") {}
if cfg!(feature = "debugging") == is_debug {}
if is_debug == m!(func) {}
if m!(func) == is_debug {}
}
#[allow(clippy::unnecessary_cast)]
fn issue9907() {
let _ = ((1 < 2) == false) as usize;
//~^ bool_comparison
let _ = (false == m!(func)) as usize;
//~^ bool_comparison
// This is not part of the issue, but an unexpected found when fixing the issue,
// the provided span was inside of macro rather than the macro callsite.
let _ = ((1 < 2) > m!(func)) as usize;
//~^ bool_comparison
}
#[allow(clippy::nonminimal_bool)]
fn issue15367() {
let a = true;
let b = false;
// these cases are handled by `nonminimal_bool`, so don't double-lint
if a == !b {};
if !a == b {};
if b == !a {};
if !b == a {};
}
fn issue15497() {
fn func() -> bool {
true
}
fn foo(x: bool) -> bool {
x > m!(func)
//~^ bool_comparison
}
fn bar(x: bool) -> bool {
x < m!(func)
//~^ bool_comparison
}
}
|
