blob: b732d7d142fc5708aef6c3e35cf1152eb94b03fd (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
|
#![allow(unused)]
#![warn(clippy::impossible_comparisons)]
#![warn(clippy::redundant_comparisons)]
#![allow(clippy::no_effect)]
#![allow(clippy::short_circuit_statement)]
#![allow(clippy::manual_range_contains)]
const STATUS_BAD_REQUEST: u16 = 400;
const STATUS_SERVER_ERROR: u16 = 500;
struct Status {
code: u16,
}
impl PartialEq<u16> for Status {
fn eq(&self, other: &u16) -> bool {
self.code == *other
}
}
impl PartialOrd<u16> for Status {
fn partial_cmp(&self, other: &u16) -> Option<std::cmp::Ordering> {
self.code.partial_cmp(other)
}
}
impl PartialEq<Status> for u16 {
fn eq(&self, other: &Status) -> bool {
*self == other.code
}
}
impl PartialOrd<Status> for u16 {
fn partial_cmp(&self, other: &Status) -> Option<std::cmp::Ordering> {
self.partial_cmp(&other.code)
}
}
fn main() {
let status_code = 500; // Value doesn't matter for the lint
let status = Status { code: status_code };
// Correct
status_code >= 400 && status_code < 500;
status_code <= 400 && status_code > 500;
//~^ impossible_comparisons
status_code > 500 && status_code < 400;
//~^ impossible_comparisons
status_code < 500 && status_code > 500;
//~^ impossible_comparisons
// More complex expressions
status_code < { 400 } && status_code > { 500 };
//~^ impossible_comparisons
status_code < STATUS_BAD_REQUEST && status_code > STATUS_SERVER_ERROR;
//~^ impossible_comparisons
status_code <= u16::MIN + 1 && status_code > STATUS_SERVER_ERROR;
//~^ impossible_comparisons
status_code < STATUS_SERVER_ERROR && status_code > STATUS_SERVER_ERROR;
//~^ impossible_comparisons
// Comparing two different types, via the `impl PartialOrd<u16> for Status`
status < { 400 } && status > { 500 };
//~^ impossible_comparisons
status < STATUS_BAD_REQUEST && status > STATUS_SERVER_ERROR;
//~^ impossible_comparisons
status <= u16::MIN + 1 && status > STATUS_SERVER_ERROR;
//~^ impossible_comparisons
status < STATUS_SERVER_ERROR && status > STATUS_SERVER_ERROR;
//~^ impossible_comparisons
// Yoda conditions
// Correct
500 <= status_code && 600 > status_code;
// Correct
500 <= status_code && status_code <= 600;
// Incorrect
500 >= status_code && 600 < status_code;
//~^ impossible_comparisons
// Incorrect
500 >= status_code && status_code > 600;
//~^ impossible_comparisons
// Yoda conditions, comparing two different types
// Correct
500 <= status && 600 > status;
// Correct
500 <= status && status <= 600;
// Incorrect
500 >= status && 600 < status;
//~^ impossible_comparisons
// Incorrect
500 >= status && status > 600;
//~^ impossible_comparisons
// Expressions where one of the sides has no effect
status_code < 200 && status_code <= 299;
//~^ redundant_comparisons
status_code > 200 && status_code >= 299;
//~^ redundant_comparisons
// Useless left
status_code >= 500 && status_code > 500;
//~^ redundant_comparisons
// Useless right
status_code > 500 && status_code >= 500;
//~^ redundant_comparisons
// Useless left
status_code <= 500 && status_code < 500;
//~^ redundant_comparisons
// Useless right
status_code < 500 && status_code <= 500;
//~^ redundant_comparisons
// Other types
let name = "Steve";
name < "Jennifer" && name > "Shannon";
//~^ impossible_comparisons
let numbers = [1, 2];
numbers < [3, 4] && numbers > [5, 6];
//~^ impossible_comparisons
let letter = 'a';
letter < 'b' && letter > 'c';
//~^ impossible_comparisons
let area = 42.0;
area < std::f32::consts::E && area > std::f32::consts::PI;
//~^ impossible_comparisons
}
|
