blob: e1dd79026839b63aa1567a6eeea6cf9da637fdfa (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
|
#![feature(f128)]
#![feature(f16)]
#![warn(clippy::float_equality_without_abs)]
//@no-rustfix: suggestions cause type ambiguity
pub fn is_roughly_equal(a: f32, b: f32) -> bool {
(a - b) < f32::EPSILON
//~^ float_equality_without_abs
}
pub fn main() {
// all errors
is_roughly_equal(1.0, 2.0);
let a = 0.05;
let b = 0.0500001;
let _ = (a - b) < f32::EPSILON;
//~^ float_equality_without_abs
let _ = a - b < f32::EPSILON;
//~^ float_equality_without_abs
let _ = a - b.abs() < f32::EPSILON;
//~^ float_equality_without_abs
let _ = (a as f64 - b as f64) < f64::EPSILON;
//~^ float_equality_without_abs
let _ = 1.0 - 2.0 < f32::EPSILON;
//~^ float_equality_without_abs
let _ = f32::EPSILON > (a - b);
//~^ float_equality_without_abs
let _ = f32::EPSILON > a - b;
//~^ float_equality_without_abs
let _ = f32::EPSILON > a - b.abs();
//~^ float_equality_without_abs
let _ = f64::EPSILON > (a as f64 - b as f64);
//~^ float_equality_without_abs
let _ = f32::EPSILON > 1.0 - 2.0;
//~^ float_equality_without_abs
let _ = (a as f16 - b as f16) < f16::EPSILON;
//~^ float_equality_without_abs
let _ = (a as f128 - b as f128) < f128::EPSILON;
//~^ float_equality_without_abs
// those are correct
let _ = (a as f16 - b as f16).abs() < f16::EPSILON;
let _ = (a - b).abs() < f32::EPSILON;
let _ = (a as f64 - b as f64).abs() < f64::EPSILON;
let _ = (a as f128 - b as f128).abs() < f128::EPSILON;
let _ = f16::EPSILON > (a as f16 - b as f16).abs();
let _ = f32::EPSILON > (a - b).abs();
let _ = f64::EPSILON > (a as f64 - b as f64).abs();
let _ = f128::EPSILON > (a as f128 - b as f128).abs();
}
|