1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
|
#![warn(clippy::format_in_format_args, clippy::to_string_in_format_args)]
#![allow(unused)]
#![allow(clippy::assertions_on_constants, clippy::eq_op, clippy::uninlined_format_args)]
use std::io::{Error, Write, stdout};
use std::ops::Deref;
use std::panic::Location;
macro_rules! my_macro {
() => {
// here be dragons, do not enter (or lint)
println!("error: {}", format!("something failed at {}", Location::caller()));
};
}
macro_rules! my_other_macro {
() => {
format!("something failed at {}", Location::caller())
};
}
fn main() {
let error = Error::other("bad thing");
let x = 'x';
println!("error: {}", format!("something failed at {}", Location::caller()));
//~^ format_in_format_args
println!("{}: {}", error, format!("something failed at {}", Location::caller()));
//~^ format_in_format_args
println!("{:?}: {}", error, format!("something failed at {}", Location::caller()));
//~^ format_in_format_args
println!("{{}}: {}", format!("something failed at {}", Location::caller()));
//~^ format_in_format_args
println!(r#"error: "{}""#, format!("something failed at {}", Location::caller()));
//~^ format_in_format_args
println!("error: {}", format!(r#"something failed at "{}""#, Location::caller()));
//~^ format_in_format_args
println!("error: {}", format!("something failed at {} {0}", Location::caller()));
//~^ format_in_format_args
let _ = format!("error: {}", format!("something failed at {}", Location::caller()));
//~^ format_in_format_args
let _ = write!(
//~^ format_in_format_args
stdout(),
"error: {}",
format!("something failed at {}", Location::caller())
);
let _ = writeln!(
//~^ format_in_format_args
stdout(),
"error: {}",
format!("something failed at {}", Location::caller())
);
print!("error: {}", format!("something failed at {}", Location::caller()));
//~^ format_in_format_args
eprint!("error: {}", format!("something failed at {}", Location::caller()));
//~^ format_in_format_args
eprintln!("error: {}", format!("something failed at {}", Location::caller()));
//~^ format_in_format_args
let _ = format_args!("error: {}", format!("something failed at {}", Location::caller()));
//~^ format_in_format_args
assert!(true, "error: {}", format!("something failed at {}", Location::caller()));
//~^ format_in_format_args
assert_eq!(0, 0, "error: {}", format!("something failed at {}", Location::caller()));
//~^ format_in_format_args
assert_ne!(0, 0, "error: {}", format!("something failed at {}", Location::caller()));
//~^ format_in_format_args
panic!("error: {}", format!("something failed at {}", Location::caller()));
//~^ format_in_format_args
// negative tests
println!("error: {}", format_args!("something failed at {}", Location::caller()));
println!("error: {:>70}", format!("something failed at {}", Location::caller()));
println!("error: {} {0}", format!("something failed at {}", Location::caller()));
println!("{} and again {0}", format!("hi {}", x));
my_macro!();
println!("error: {}", my_other_macro!());
}
macro_rules! _internal {
($($args:tt)*) => {
println!("{}", format_args!($($args)*))
};
}
macro_rules! my_println2 {
($target:expr, $($args:tt)+) => {{
if $target {
_internal!($($args)+)
}
}};
}
macro_rules! my_println2_args {
($target:expr, $($args:tt)+) => {{
if $target {
_internal!("foo: {}", format_args!($($args)+))
}
}};
}
fn test2() {
let error = Error::other("bad thing");
// None of these should be linted without the config change
my_println2!(true, "error: {}", format!("something failed at {}", Location::caller()));
my_println2!(
true,
"{}: {}",
error,
format!("something failed at {}", Location::caller())
);
my_println2_args!(true, "error: {}", format!("something failed at {}", Location::caller()));
my_println2_args!(
true,
"{}: {}",
error,
format!("something failed at {}", Location::caller())
);
}
#[clippy::format_args]
macro_rules! usr_println {
($target:expr, $($args:tt)*) => {{
if $target {
println!($($args)*)
}
}};
}
fn user_format() {
let error = Error::other("bad thing");
let x = 'x';
usr_println!(true, "error: {}", format!("boom at {}", Location::caller()));
//~^ format_in_format_args
usr_println!(true, "{}: {}", error, format!("boom at {}", Location::caller()));
//~^ format_in_format_args
usr_println!(true, "{:?}: {}", error, format!("boom at {}", Location::caller()));
//~^ format_in_format_args
usr_println!(true, "{{}}: {}", format!("boom at {}", Location::caller()));
//~^ format_in_format_args
usr_println!(true, r#"error: "{}""#, format!("boom at {}", Location::caller()));
//~^ format_in_format_args
usr_println!(true, "error: {}", format!(r#"boom at "{}""#, Location::caller()));
//~^ format_in_format_args
usr_println!(true, "error: {}", format!("boom at {} {0}", Location::caller()));
//~^ format_in_format_args
}
|
