1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
|
//@compile-flags: -Zdeduplicate-diagnostics=yes
//@aux-build: proc_macros.rs
#![warn(clippy::indexing_slicing)]
// We also check the out_of_bounds_indexing lint here, because it lints similar things and
// we want to avoid false positives.
#![warn(clippy::out_of_bounds_indexing)]
#![allow(
unconditional_panic,
clippy::no_effect,
clippy::unnecessary_operation,
clippy::useless_vec
)]
extern crate proc_macros;
use proc_macros::with_span;
const ARR: [i32; 2] = [1, 2];
const REF: &i32 = &ARR[idx()]; // This should be linted, since `suppress-restriction-lint-in-const` default is false.
//~^ ERROR: indexing may panic
const fn idx() -> usize {
1
}
const fn idx4() -> usize {
4
}
with_span!(
span
fn dont_lint_proc_macro_array() {
let x = [1, 2, 3, 4];
let index: usize = 1;
x[index];
x[10];
let x = vec![0; 5];
let index: usize = 1;
x[index];
x[10];
}
);
fn main() {
let x = [1, 2, 3, 4];
let index: usize = 1;
x[index];
//~^ ERROR: indexing may panic
// Ok, let rustc's `unconditional_panic` lint handle `usize` indexing on arrays.
x[4];
//~^ out_of_bounds_indexing
// Ok, let rustc's `unconditional_panic` lint handle `usize` indexing on arrays.
x[1 << 3];
//~^ out_of_bounds_indexing
// Ok, should not produce stderr.
x[0];
// Ok, should not produce stderr.
x[3];
// Ok, should not produce stderr.
x[const { idx() }];
// Ok, let rustc's `unconditional_panic` lint handle `usize` indexing on arrays.
x[const { idx4() }];
// This should be linted, since `suppress-restriction-lint-in-const` default is false.
const { &ARR[idx()] };
//~^ ERROR: indexing may panic
// This should be linted, since `suppress-restriction-lint-in-const` default is false.
const { &ARR[idx4()] };
//~^ ERROR: indexing may panic
let y = &x;
// Ok, referencing shouldn't affect this lint. See the issue 6021
y[0];
// Ok, rustc will handle references too.
y[4];
//~^ out_of_bounds_indexing
let v = vec![0; 5];
v[0];
//~^ ERROR: indexing may panic
v[10];
//~^ ERROR: indexing may panic
v[1 << 3];
//~^ ERROR: indexing may panic
// Out of bounds
const N: usize = 15;
// In bounds
const M: usize = 3;
// Ok, let rustc's `unconditional_panic` lint handle `usize` indexing on arrays.
x[N];
//~^ out_of_bounds_indexing
// Ok, should not produce stderr.
x[M];
v[N];
//~^ ERROR: indexing may panic
v[M];
//~^ ERROR: indexing may panic
let slice = &x;
let _ = x[4];
//~^ out_of_bounds_indexing
}
|
