about summary refs log tree commit diff
path: root/src/tools/clippy/tests/ui/manual_async_fn.rs
blob: 188f8a4982c36aecd4319cdc898014e998879d6b (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
#![warn(clippy::manual_async_fn)]
#![allow(clippy::needless_pub_self, unused)]

use std::future::Future;

fn fut() -> impl Future<Output = i32> {
    //~^ manual_async_fn
    async { 42 }
}

#[rustfmt::skip]
fn fut2() ->impl Future<Output = i32> {
//~^ manual_async_fn
    async { 42 }
}

#[rustfmt::skip]
fn fut3()-> impl Future<Output = i32> {
//~^ manual_async_fn
    async { 42 }
}

fn empty_fut() -> impl Future<Output = ()> {
    //~^ manual_async_fn
    async {}
}

#[rustfmt::skip]
fn empty_fut2() ->impl Future<Output = ()> {
//~^ manual_async_fn
    async {}
}

#[rustfmt::skip]
fn empty_fut3()-> impl Future<Output = ()> {
//~^ manual_async_fn
    async {}
}

fn core_fut() -> impl core::future::Future<Output = i32> {
    //~^ manual_async_fn
    async move { 42 }
}

// should be ignored
fn has_other_stmts() -> impl core::future::Future<Output = i32> {
    let _ = 42;
    async move { 42 }
}

// should be ignored
fn not_fut() -> i32 {
    42
}

// should be ignored
async fn already_async() -> impl Future<Output = i32> {
    async { 42 }
}

struct S;
impl S {
    fn inh_fut() -> impl Future<Output = i32> {
        //~^ manual_async_fn
        async {
            // NOTE: this code is here just to check that the indentation is correct in the suggested fix
            let a = 42;
            let b = 21;
            if a < b {
                let c = 21;
                let d = 42;
                if c < d {
                    let _ = 42;
                }
            }
            42
        }
    }

    // should be ignored
    fn not_fut(&self) -> i32 {
        42
    }

    // should be ignored
    fn has_other_stmts() -> impl core::future::Future<Output = i32> {
        let _ = 42;
        async move { 42 }
    }

    // should be ignored
    async fn already_async(&self) -> impl Future<Output = i32> {
        async { 42 }
    }
}

// Tests related to lifetime capture

fn elided(_: &i32) -> impl Future<Output = i32> + '_ {
    //~^ manual_async_fn
    async { 42 }
}

// should be ignored
fn elided_not_bound(_: &i32) -> impl Future<Output = i32> + use<> {
    async { 42 }
}

#[allow(clippy::needless_lifetimes)]
fn explicit<'a, 'b>(_: &'a i32, _: &'b i32) -> impl Future<Output = i32> + 'a + 'b {
    //~^ manual_async_fn
    async { 42 }
}

// should be ignored
#[allow(clippy::needless_lifetimes)]
fn explicit_not_bound<'a, 'b>(_: &'a i32, _: &'b i32) -> impl Future<Output = i32> + use<> {
    async { 42 }
}

// should be ignored
mod issue_5765 {
    use std::future::Future;

    struct A;
    impl A {
        fn f(&self) -> impl Future<Output = ()> + use<> {
            async {}
        }
    }

    fn test() {
        let _future = {
            let a = A;
            a.f()
        };
    }
}

pub fn issue_10450() -> impl Future<Output = i32> {
    //~^ manual_async_fn
    async { 42 }
}

pub(crate) fn issue_10450_2() -> impl Future<Output = i32> {
    //~^ manual_async_fn
    async { 42 }
}

pub(self) fn issue_10450_3() -> impl Future<Output = i32> {
    //~^ manual_async_fn
    async { 42 }
}

macro_rules! issue_12407 {
    (
        $(
            $(#[$m:meta])*
            $v:vis $(override($($overrides:tt),* $(,)?))? fn $name:ident $([$($params:tt)*])? (
                $($arg_name:ident: $arg_typ:ty),* $(,)?
            ) $(-> $ret_ty:ty)? = $e:expr;
        )*
    ) => {
        $(
            $(#[$m])*
            $v $($($overrides)*)? fn $name$(<$($params)*>)?(
                $($arg_name: $arg_typ),*
            ) $(-> $ret_ty)? {
                $e
            }
        )*
    };
}

issue_12407! {
    fn _hello() -> impl Future<Output = ()> = async {};
    fn non_async() = println!("hello");
    fn foo() = non_async();
}

fn main() {}