1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
|
#![warn(clippy::manual_map)]
#![allow(
clippy::no_effect,
clippy::map_identity,
clippy::unit_arg,
clippy::match_ref_pats,
clippy::redundant_pattern_matching,
clippy::unnecessary_map_on_constructor,
for_loops_over_fallibles,
dead_code
)]
fn main() {
match Some(0) {
//~^ manual_map
Some(_) => Some(2),
None::<u32> => None,
};
match Some(0) {
//~^ manual_map
Some(x) => Some(x + 1),
_ => None,
};
match Some("") {
//~^ manual_map
Some(x) => Some(x.is_empty()),
None => None,
};
if let Some(x) = Some(0) {
//~^ manual_map
Some(!x)
} else {
None
};
#[rustfmt::skip]
match Some(0) {
//~^ manual_map
Some(x) => { Some(std::convert::identity(x)) }
None => { None }
};
match Some(&String::new()) {
//~^ manual_map
Some(x) => Some(str::len(x)),
None => None,
};
match Some(0) {
Some(x) if false => Some(x + 1),
_ => None,
};
match &Some([0, 1]) {
//~^ manual_map
Some(x) => Some(x[0]),
&None => None,
};
match &Some(0) {
//~^ manual_map
&Some(x) => Some(x * 2),
None => None,
};
match Some(String::new()) {
//~^ manual_map
Some(ref x) => Some(x.is_empty()),
_ => None,
};
match &&Some(String::new()) {
//~^ manual_map
Some(x) => Some(x.len()),
_ => None,
};
match &&Some(0) {
//~^ manual_map
&&Some(x) => Some(x + x),
&&_ => None,
};
#[warn(clippy::option_map_unit_fn)]
match &mut Some(String::new()) {
Some(x) => Some(x.push_str("")),
None => None,
};
#[allow(clippy::option_map_unit_fn)]
{
match &mut Some(String::new()) {
//~^ manual_map
Some(x) => Some(x.push_str("")),
None => None,
};
}
match &mut Some(String::new()) {
//~^ manual_map
&mut Some(ref x) => Some(x.len()),
None => None,
};
match &mut &Some(String::new()) {
//~^ manual_map
Some(x) => Some(x.is_empty()),
&mut _ => None,
};
match Some((0, 1, 2)) {
//~^ manual_map
Some((x, y, z)) => Some(x + y + z),
None => None,
};
match Some([1, 2, 3]) {
//~^ manual_map
Some([first, ..]) => Some(first),
None => None,
};
match &Some((String::new(), "test")) {
//~^ manual_map
Some((x, y)) => Some((y, x)),
None => None,
};
match Some((String::new(), 0)) {
Some((ref x, y)) => Some((y, x)),
None => None,
};
match Some(Some(0)) {
Some(Some(_)) | Some(None) => Some(0),
None => None,
};
match Some(Some((0, 1))) {
Some(Some((x, 1))) => Some(x),
_ => None,
};
// #6795
fn f1() -> Result<(), ()> {
let _ = match Some(Ok(())) {
Some(x) => Some(x?),
None => None,
};
Ok(())
}
for &x in Some(Some(true)).iter() {
let _ = match x {
Some(x) => Some(if x { continue } else { x }),
None => None,
};
}
// #6797
let x1 = (Some(String::new()), 0);
let x2 = x1.0;
match x2 {
Some(x) => Some((x, x1.1)),
None => None,
};
struct S1 {
x: Option<String>,
y: u32,
}
impl S1 {
fn f(self) -> Option<(String, u32)> {
match self.x {
Some(x) => Some((x, self.y)),
None => None,
}
}
}
// #6811
match Some(0) {
Some(x) => Some(vec![x]),
None => None,
};
// Don't lint, coercion
let x: Option<Vec<&[u8]>> = match Some(()) {
Some(_) => Some(vec![b"1234"]),
None => None,
};
match option_env!("") {
//~^ manual_map
Some(x) => Some(String::from(x)),
None => None,
};
// #6819
async fn f2(x: u32) -> u32 {
x
}
async fn f3() {
match Some(0) {
Some(x) => Some(f2(x).await),
None => None,
};
}
// #6847
if let Some(_) = Some(0) {
Some(0)
} else if let Some(x) = Some(0) {
//~^ manual_map
Some(x + 1)
} else {
None
};
if true {
Some(0)
} else if let Some(x) = Some(0) {
//~^ manual_map
Some(x + 1)
} else {
None
};
// #6967
const fn f4() {
match Some(0) {
Some(x) => Some(x + 1),
None => None,
};
}
// #7077
let s = &String::new();
#[allow(clippy::needless_match)]
let _: Option<&str> = match Some(s) {
Some(s) => Some(s),
None => None,
};
}
|
