1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
|
error: manual implementation of `Option::map`
--> tests/ui/manual_map_option_2.rs:6:13
|
LL | let _ = match Some(0) {
| _____________^
LL | |
LL | | Some(x) => Some({
LL | | let y = (String::new(), String::new());
... |
LL | | None => None,
LL | | };
| |_____^
|
= note: `-D clippy::manual-map` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::manual_map)]`
help: try
|
LL ~ let _ = Some(0).map(|x| {
LL + let y = (String::new(), String::new());
LL + (x, y.0)
LL ~ });
|
error: manual implementation of `Option::map`
--> tests/ui/manual_map_option_2.rs:49:13
|
LL | let _ = match &s {
| _____________^
LL | |
LL | | Some(x) => Some({ if let Some(ref s) = s { (x.clone(), s) } else { panic!() } }),
LL | | None => None,
LL | | };
| |_____^ help: try: `s.as_ref().map(|x| { if let Some(ref s) = s { (x.clone(), s) } else { panic!() } })`
error: manual implementation of `Option::map`
--> tests/ui/manual_map_option_2.rs:65:17
|
LL | let _ = match Some(0) {
| _________________^
LL | |
LL | | Some(x) => Some(f(x)),
LL | | None => None,
LL | | };
| |_________^ help: try: `Some(0).map(|x| f(x))`
error: manual implementation of `Option::map`
--> tests/ui/manual_map_option_2.rs:71:13
|
LL | let _ = match Some(0) {
| _____________^
LL | |
LL | | Some(x) => unsafe { Some(f(x)) },
LL | | None => None,
LL | | };
| |_____^ help: try: `Some(0).map(|x| unsafe { f(x) })`
error: manual implementation of `Option::map`
--> tests/ui/manual_map_option_2.rs:76:13
|
LL | let _ = match Some(0) {
| _____________^
LL | |
LL | | Some(x) => Some(unsafe { f(x) }),
LL | | None => None,
LL | | };
| |_____^ help: try: `Some(0).map(|x| unsafe { f(x) })`
error: manual implementation of `Option::map`
--> tests/ui/manual_map_option_2.rs:113:17
|
LL | let _ = match Some(0) {
| _________________^
LL | |
LL | | Some(_) => Some(match f() {
LL | | Ok(res) => Ok(Box::new(res)),
... |
LL | | None => None,
LL | | };
| |_________^
|
help: try
|
LL ~ let _ = Some(0).map(|_| match f() {
LL + Ok(res) => Ok(Box::new(res)),
LL + _ => Err(()),
LL ~ });
|
error: manual implementation of `Option::map`
--> tests/ui/manual_map_option_2.rs:136:37
|
LL | let _: Option<Box<&[u8]>> = match Some(0) {
| _____________________________________^
LL | |
LL | | Some(_) => Some(g(x)),
LL | | None => None,
LL | | };
| |_________^ help: try: `Some(0).map(|_| g(x))`
error: aborting due to 7 previous errors
|
