blob: 80e3f50692770e74af2035dd31016986b0459f8b (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
|
#![allow(clippy::mut_mut)]
fn takes_ref(a: &i32) {}
fn takes_refmut(a: &mut i32) {}
fn takes_ref_ref(a: &&i32) {}
fn takes_refmut_ref(a: &mut &i32) {}
fn takes_ref_refmut(a: &&mut i32) {}
fn takes_refmut_refmut(a: &mut &mut i32) {}
fn takes_raw_const(a: *const i32) {}
fn takes_raw_mut(a: *mut i32) {}
mod issue11268 {
macro_rules! x {
(1 $f:expr) => {
$f(&mut 1);
};
(2 $f:expr) => {
$f(&mut &1)
};
(3 $f:expr) => {
$f(&mut &mut 1)
};
(4 $f:expr) => {
let mut a = 1;
$f(&raw mut a)
};
}
fn f() {
x!(1 super::takes_ref);
x!(1 super::takes_refmut);
x!(2 super::takes_refmut_ref);
x!(3 super::takes_ref_refmut);
x!(3 super::takes_refmut_refmut);
x!(4 super::takes_raw_const);
x!(4 super::takes_raw_mut);
}
}
struct MyStruct;
impl MyStruct {
fn takes_ref(&self, a: &i32) {}
fn takes_refmut(&self, a: &mut i32) {}
fn takes_ref_ref(&self, a: &&i32) {}
fn takes_refmut_ref(&self, a: &mut &i32) {}
fn takes_ref_refmut(&self, a: &&mut i32) {}
fn takes_refmut_refmut(&self, a: &mut &mut i32) {}
fn takes_raw_const(&self, a: *const i32) {}
fn takes_raw_mut(&self, a: *mut i32) {}
}
#[warn(clippy::unnecessary_mut_passed)]
fn main() {
// Functions
takes_ref(&mut 42);
//~^ unnecessary_mut_passed
takes_ref_ref(&mut &42);
//~^ unnecessary_mut_passed
takes_ref_refmut(&mut &mut 42);
//~^ unnecessary_mut_passed
takes_raw_const(&mut 42);
//~^ unnecessary_mut_passed
let as_ptr: fn(&i32) = takes_ref;
as_ptr(&mut 42);
//~^ unnecessary_mut_passed
let as_ptr: fn(&&i32) = takes_ref_ref;
as_ptr(&mut &42);
//~^ unnecessary_mut_passed
let as_ptr: fn(&&mut i32) = takes_ref_refmut;
as_ptr(&mut &mut 42);
//~^ unnecessary_mut_passed
let as_ptr: fn(*const i32) = takes_raw_const;
as_ptr(&mut 42);
//~^ unnecessary_mut_passed
// Methods
let my_struct = MyStruct;
my_struct.takes_ref(&mut 42);
//~^ unnecessary_mut_passed
my_struct.takes_ref_ref(&mut &42);
//~^ unnecessary_mut_passed
my_struct.takes_ref_refmut(&mut &mut 42);
//~^ unnecessary_mut_passed
my_struct.takes_raw_const(&mut 42);
//~^ unnecessary_mut_passed
// No error
// Functions
takes_ref(&42);
let as_ptr: fn(&i32) = takes_ref;
as_ptr(&42);
takes_refmut(&mut 42);
let as_ptr: fn(&mut i32) = takes_refmut;
as_ptr(&mut 42);
takes_ref_ref(&&42);
let as_ptr: fn(&&i32) = takes_ref_ref;
as_ptr(&&42);
takes_refmut_ref(&mut &42);
let as_ptr: fn(&mut &i32) = takes_refmut_ref;
as_ptr(&mut &42);
takes_ref_refmut(&&mut 42);
let as_ptr: fn(&&mut i32) = takes_ref_refmut;
as_ptr(&&mut 42);
takes_refmut_refmut(&mut &mut 42);
let as_ptr: fn(&mut &mut i32) = takes_refmut_refmut;
as_ptr(&mut &mut 42);
takes_raw_const(&42);
let as_ptr: fn(*const i32) = takes_raw_const;
as_ptr(&42);
takes_raw_mut(&mut 42);
let as_ptr: fn(*mut i32) = takes_raw_mut;
as_ptr(&mut 42);
let a = &mut 42;
let b = &mut &42;
let c = &mut &mut 42;
takes_ref(a);
takes_ref_ref(b);
takes_ref_refmut(c);
takes_raw_const(a);
// Methods
my_struct.takes_ref(&42);
my_struct.takes_refmut(&mut 42);
my_struct.takes_ref_ref(&&42);
my_struct.takes_refmut_ref(&mut &42);
my_struct.takes_ref_refmut(&&mut 42);
my_struct.takes_refmut_refmut(&mut &mut 42);
my_struct.takes_raw_const(&42);
my_struct.takes_raw_mut(&mut 42);
my_struct.takes_ref(a);
my_struct.takes_ref_ref(b);
my_struct.takes_ref_refmut(c);
my_struct.takes_raw_const(a);
my_struct.takes_raw_mut(a);
}
// not supported currently
fn raw_ptrs(my_struct: MyStruct) {
let mut n = 42;
takes_raw_const(&raw mut n);
let as_ptr: fn(*const i32) = takes_raw_const;
as_ptr(&raw mut n);
my_struct.takes_raw_const(&raw mut n);
// No error
takes_raw_const(&raw const n);
takes_raw_mut(&raw mut n);
let a = &raw mut n;
takes_raw_const(a);
my_struct.takes_raw_const(&raw const n);
my_struct.takes_raw_mut(&raw mut n);
my_struct.takes_raw_const(a);
}
|
