src/tools/clippy/tests/ui/needless_as_bytes.fixed


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50

#![warn(clippy::needless_as_bytes)]
#![allow(clippy::const_is_empty)]

struct S;

impl S {
    fn as_bytes(&self) -> &[u8] {
        &[]
    }
}

fn main() {
    if "some string".is_empty() {
        //~^ needless_as_bytes
        println!("len = {}", "some string".len());
        //~^ needless_as_bytes
    }

    let s = String::from("yet another string");
    if s.is_empty() {
        //~^ needless_as_bytes
        println!("len = {}", s.len());
        //~^ needless_as_bytes
    }

    // Do not lint
    let _ = S.as_bytes().is_empty();
    let _ = S.as_bytes().len();
    let _ = (&String::new() as &dyn AsBytes).as_bytes().len();
    macro_rules! m {
        (1) => {
            ""
        };
        (2) => {
            "".as_bytes()
        };
    }
    m!(1).as_bytes().len();
    m!(2).len();
}

pub trait AsBytes {
    fn as_bytes(&self) -> &[u8];
}

impl AsBytes for String {
    fn as_bytes(&self) -> &[u8] {
        &[]
    }
}