1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
|
#![warn(clippy::needless_bool)]
#![allow(
unused,
dead_code,
clippy::no_effect,
clippy::if_same_then_else,
clippy::equatable_if_let,
clippy::needless_if,
clippy::needless_return,
clippy::self_named_constructors,
clippy::struct_field_names
)]
use std::cell::Cell;
macro_rules! bool_comparison_trigger {
($($i:ident: $def:expr, $stb:expr );+ $(;)*) => (
#[derive(Clone)]
pub struct Trigger {
$($i: (Cell<bool>, bool, bool)),+
}
#[allow(dead_code)]
impl Trigger {
pub fn trigger(&self, key: &str) -> bool {
$(
if let stringify!($i) = key {
return self.$i.1 && self.$i.2 == $def;
}
)+
false
}
}
)
}
fn main() {
let x = true;
let y = false;
if x {
true
} else {
false
};
//~^^^^^ needless_bool
if x {
false
} else {
true
};
//~^^^^^ needless_bool
if x && y {
false
} else {
true
};
//~^^^^^ needless_bool
let a = 0;
let b = 1;
if a == b {
false
} else {
true
};
//~^^^^^ needless_bool
if a != b {
false
} else {
true
};
//~^^^^^ needless_bool
if a < b {
false
} else {
true
};
//~^^^^^ needless_bool
if a <= b {
false
} else {
true
};
//~^^^^^ needless_bool
if a > b {
false
} else {
true
};
//~^^^^^ needless_bool
if a >= b {
false
} else {
true
};
//~^^^^^ needless_bool
if x {
x
} else {
false
}; // would also be questionable, but we don't catch this yet
bool_ret3(x);
bool_ret4(x);
bool_ret5(x, x);
bool_ret6(x, x);
needless_bool(x);
needless_bool2(x);
needless_bool3(x);
needless_bool_condition();
if a == b {
true
} else {
// Do not lint as this comment might be important
false
};
}
fn bool_ret3(x: bool) -> bool {
if x {
return true;
} else {
return false;
};
//~^^^^^ needless_bool
}
fn bool_ret4(x: bool) -> bool {
if x {
return false;
} else {
return true;
};
//~^^^^^ needless_bool
}
fn bool_ret5(x: bool, y: bool) -> bool {
if x && y {
return true;
} else {
return false;
};
//~^^^^^ needless_bool
}
fn bool_ret6(x: bool, y: bool) -> bool {
if x && y {
return false;
} else {
return true;
};
//~^^^^^ needless_bool
}
fn needless_bool(x: bool) {
if x == true {};
//~^ bool_comparison
}
fn needless_bool2(x: bool) {
if x == false {};
//~^ bool_comparison
}
fn needless_bool3(x: bool) {
bool_comparison_trigger! {
test_one: false, false;
test_three: false, false;
test_two: true, true;
}
if x == true {};
//~^ bool_comparison
if x == false {};
//~^ bool_comparison
}
fn needless_bool_in_the_suggestion_wraps_the_predicate_of_if_else_statement_in_brackets() {
let b = false;
let returns_bool = || false;
let x = if b {
true
} else if returns_bool() {
false
} else {
true
};
//~^^^^^ needless_bool
}
unsafe fn no(v: u8) -> u8 {
v
}
#[allow(clippy::unnecessary_operation)]
fn needless_bool_condition() -> bool {
if unsafe { no(4) } & 1 != 0 {
true
} else {
false
};
//~^^^^^ needless_bool
let _brackets_unneeded = if unsafe { no(4) } & 1 != 0 { true } else { false };
//~^ needless_bool
fn foo() -> bool {
// parentheses are needed here
if unsafe { no(4) } & 1 != 0 { true } else { false }
//~^ needless_bool
}
foo()
}
fn issue12846() {
let a = true;
let b = false;
// parentheses are needed here
let _x = if a && b { true } else { false }.then(|| todo!());
//~^ needless_bool
let _x = if a && b { true } else { false } as u8;
//~^ needless_bool
// parentheses are not needed here
let _x = if a { true } else { false }.then(|| todo!());
//~^ needless_bool
}
|
