blob: 204cfa36b0221ace2b7347539ff45edbc62b920d (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
|
error: needless use of `for_each`
--> tests/ui/needless_for_each_fixable.rs:15:5
|
LL | / v.iter().for_each(|elem| {
LL | |
LL | | acc += elem;
LL | | });
| |_______^
|
= note: `-D clippy::needless-for-each` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_for_each)]`
help: try
|
LL ~ for elem in v.iter() {
LL +
LL + acc += elem;
LL + }
|
error: needless use of `for_each`
--> tests/ui/needless_for_each_fixable.rs:19:5
|
LL | / v.into_iter().for_each(|elem| {
LL | |
LL | | acc += elem;
LL | | });
| |_______^
|
help: try
|
LL ~ for elem in v.into_iter() {
LL +
LL + acc += elem;
LL + }
|
error: needless use of `for_each`
--> tests/ui/needless_for_each_fixable.rs:24:5
|
LL | / [1, 2, 3].iter().for_each(|elem| {
LL | |
LL | | acc += elem;
LL | | });
| |_______^
|
help: try
|
LL ~ for elem in [1, 2, 3].iter() {
LL +
LL + acc += elem;
LL + }
|
error: needless use of `for_each`
--> tests/ui/needless_for_each_fixable.rs:30:5
|
LL | / hash_map.iter().for_each(|(k, v)| {
LL | |
LL | | acc += k + v;
LL | | });
| |_______^
|
help: try
|
LL ~ for (k, v) in hash_map.iter() {
LL +
LL + acc += k + v;
LL + }
|
error: needless use of `for_each`
--> tests/ui/needless_for_each_fixable.rs:34:5
|
LL | / hash_map.iter_mut().for_each(|(k, v)| {
LL | |
LL | | acc += *k + *v;
LL | | });
| |_______^
|
help: try
|
LL ~ for (k, v) in hash_map.iter_mut() {
LL +
LL + acc += *k + *v;
LL + }
|
error: needless use of `for_each`
--> tests/ui/needless_for_each_fixable.rs:38:5
|
LL | / hash_map.keys().for_each(|k| {
LL | |
LL | | acc += k;
LL | | });
| |_______^
|
help: try
|
LL ~ for k in hash_map.keys() {
LL +
LL + acc += k;
LL + }
|
error: needless use of `for_each`
--> tests/ui/needless_for_each_fixable.rs:42:5
|
LL | / hash_map.values().for_each(|v| {
LL | |
LL | | acc += v;
LL | | });
| |_______^
|
help: try
|
LL ~ for v in hash_map.values() {
LL +
LL + acc += v;
LL + }
|
error: needless use of `for_each`
--> tests/ui/needless_for_each_fixable.rs:50:5
|
LL | / my_vec().iter().for_each(|elem| {
LL | |
LL | | acc += elem;
LL | | });
| |_______^
|
help: try
|
LL ~ for elem in my_vec().iter() {
LL +
LL + acc += elem;
LL + }
|
error: needless use of `for_each`
--> tests/ui/needless_for_each_fixable.rs:135:9
|
LL | rows.iter().for_each(|x| _ = v.push(x));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x in rows.iter() { _ = v.push(x) }`
error: needless use of `for_each`
--> tests/ui/needless_for_each_fixable.rs:142:9
|
LL | rows.iter().for_each(|x| do_something(x, 1u8));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x in rows.iter() { do_something(x, 1u8); }`
error: needless use of `for_each`
--> tests/ui/needless_for_each_fixable.rs:149:5
|
LL | vec.iter().for_each(|v| println!("{v}"));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for v in vec.iter() { println!("{v}"); }`
error: aborting due to 11 previous errors
|
