blob: 241a72c6d990d82919b57189eb6d61e9ffd77035 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
|
#![warn(clippy::neg_multiply)]
#![allow(clippy::no_effect, clippy::unnecessary_operation, clippy::precedence)]
#![allow(unused)]
use std::ops::Mul;
struct X;
impl Mul<isize> for X {
type Output = X;
fn mul(self, _r: isize) -> Self {
self
}
}
impl Mul<X> for isize {
type Output = X;
fn mul(self, _r: X) -> X {
X
}
}
fn main() {
let x = 0;
x * -1;
//~^ neg_multiply
-1 * x;
//~^ neg_multiply
100 + x * -1;
//~^ neg_multiply
(100 + x) * -1;
//~^ neg_multiply
-1 * 17;
//~^ neg_multiply
0xcafe | 0xff00 * -1;
//~^ neg_multiply
3_usize as i32 * -1;
//~^ neg_multiply
(3_usize as i32) * -1;
//~^ neg_multiply
-1 * -1; // should be ok
X * -1; // should be ok
-1 * X; // should also be ok
}
fn float() {
let x = 0.0;
x * -1.0;
//~^ neg_multiply
-1.0 * x;
//~^ neg_multiply
100.0 + x * -1.0;
//~^ neg_multiply
(100.0 + x) * -1.0;
//~^ neg_multiply
-1.0 * 17.0;
//~^ neg_multiply
0.0 + 0.0 * -1.0;
//~^ neg_multiply
3.0_f32 as f64 * -1.0;
//~^ neg_multiply
(3.0_f32 as f64) * -1.0;
//~^ neg_multiply
-1.0 * -1.0; // should be ok
}
struct Y {
delta: f64,
}
fn nested() {
let a = Y { delta: 1.0 };
let b = Y { delta: 1.0 };
let _ = ((a.delta - 0.5).abs() * -1.0).total_cmp(&1.0);
//~^ neg_multiply
let _ = (-(a.delta - 0.5).abs()).total_cmp(&1.0);
}
|
