blob: 8e1f57ca2c026e0ab0c4569efdee278d99b9a256 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
|
#![warn(clippy::obfuscated_if_else)]
#![allow(
clippy::unnecessary_lazy_evaluations,
clippy::unit_arg,
clippy::unused_unit,
clippy::unwrap_or_default
)]
fn main() {
true.then_some("a").unwrap_or("b");
//~^ obfuscated_if_else
true.then(|| "a").unwrap_or("b");
//~^ obfuscated_if_else
let a = 1;
(a == 1).then_some("a").unwrap_or("b");
//~^ obfuscated_if_else
(a == 1).then(|| "a").unwrap_or("b");
//~^ obfuscated_if_else
let partial = (a == 1).then_some("a");
partial.unwrap_or("b"); // not lint
let mut a = 0;
true.then_some(a += 1).unwrap_or(());
//~^ obfuscated_if_else
true.then_some(()).unwrap_or(a += 2);
//~^ obfuscated_if_else
let mut n = 1;
true.then(|| n = 1).unwrap_or_else(|| n = 2);
//~^ obfuscated_if_else
true.then_some(1).unwrap_or_else(|| n * 2);
//~^ obfuscated_if_else
true.then_some(n += 1).unwrap_or_else(|| ());
//~^ obfuscated_if_else
let _ = true.then_some(1).unwrap_or_else(|| n * 2);
//~^ obfuscated_if_else
true.then_some(1).unwrap_or_else(Default::default);
//~^ obfuscated_if_else
let partial = true.then_some(1);
partial.unwrap_or_else(|| n * 2); // not lint
true.then_some(()).unwrap_or_default();
//~^ obfuscated_if_else
true.then(|| ()).unwrap_or_default();
//~^ obfuscated_if_else
true.then_some(1).unwrap_or_default();
//~^ obfuscated_if_else
true.then(|| 1).unwrap_or_default();
//~^ obfuscated_if_else
}
fn issue11141() {
// Parentheses are required around the left side of a binary expression
let _ = true.then_some(40).unwrap_or(17) | 2;
//~^ obfuscated_if_else
// Parentheses are required only for the leftmost expression
let _ = true.then_some(30).unwrap_or(17) | true.then_some(2).unwrap_or(3) | true.then_some(10).unwrap_or(1);
//~^ obfuscated_if_else
//~| obfuscated_if_else
//~| obfuscated_if_else
// Parentheses are not required around the right side of a binary expression
let _ = 2 | true.then_some(40).unwrap_or(17);
//~^ obfuscated_if_else
// Parentheses are not required for a cast
let _ = true.then_some(42).unwrap_or(17) as u8;
//~^ obfuscated_if_else
// Parentheses are not required for a deref
let _ = *true.then_some(&42).unwrap_or(&17);
//~^ obfuscated_if_else
// Parentheses are not required for a deref followed by a cast
let _ = *true.then_some(&42).unwrap_or(&17) as u8;
//~^ obfuscated_if_else
}
|
