1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
|
#![warn(clippy::redundant_pattern_matching)]
#![allow(deprecated)]
#![allow(
clippy::if_same_then_else,
clippy::match_like_matches_macro,
clippy::needless_bool,
clippy::needless_if,
clippy::uninlined_format_args,
clippy::unnecessary_wraps
)]
fn main() {
let result: Result<usize, usize> = Err(5);
if result.is_ok() {}
//~^ redundant_pattern_matching
if Ok::<i32, i32>(42).is_ok() {}
//~^ redundant_pattern_matching
if Err::<i32, i32>(42).is_err() {}
//~^ redundant_pattern_matching
while Ok::<i32, i32>(10).is_ok() {}
//~^ redundant_pattern_matching
while Ok::<i32, i32>(10).is_err() {}
//~^ redundant_pattern_matching
if Ok::<i32, i32>(42).is_ok() {}
if Err::<i32, i32>(42).is_err() {}
if let Ok(x) = Ok::<i32, i32>(42) {
println!("{}", x);
}
Ok::<i32, i32>(42).is_ok();
Ok::<i32, i32>(42).is_err();
Err::<i32, i32>(42).is_err();
Err::<i32, i32>(42).is_ok();
let _ = if Ok::<usize, ()>(4).is_ok() { true } else { false };
//~^ redundant_pattern_matching
issue5504();
issue6067();
issue6065();
issue10726();
issue10803();
let _ = if gen_res().is_ok() {
//~^ redundant_pattern_matching
1
} else if gen_res().is_err() {
//~^ redundant_pattern_matching
2
} else {
3
};
}
fn gen_res() -> Result<(), ()> {
Ok(())
}
macro_rules! m {
() => {
Some(42u32)
};
}
fn issue5504() {
fn result_opt() -> Result<Option<i32>, i32> {
Err(42)
}
fn try_result_opt() -> Result<i32, i32> {
while r#try!(result_opt()).is_some() {}
//~^ redundant_pattern_matching
if r#try!(result_opt()).is_some() {}
//~^ redundant_pattern_matching
Ok(42)
}
try_result_opt();
if m!().is_some() {}
//~^ redundant_pattern_matching
while m!().is_some() {}
//~^ redundant_pattern_matching
}
fn issue6065() {
macro_rules! if_let_in_macro {
($pat:pat, $x:expr) => {
if let Some($pat) = $x {}
};
}
// shouldn't be linted
if_let_in_macro!(_, Some(42));
}
// Methods that are unstable const should not be suggested within a const context, see issue #5697.
// However, in Rust 1.48.0 the methods `is_ok` and `is_err` of `Result` were stabilized as const,
// so the following should be linted.
const fn issue6067() {
if Ok::<i32, i32>(42).is_ok() {}
//~^ redundant_pattern_matching
if Err::<i32, i32>(42).is_err() {}
//~^ redundant_pattern_matching
while Ok::<i32, i32>(10).is_ok() {}
//~^ redundant_pattern_matching
while Ok::<i32, i32>(10).is_err() {}
//~^ redundant_pattern_matching
Ok::<i32, i32>(42).is_ok();
Err::<i32, i32>(42).is_err();
}
fn issue10726() {
// This is optional, but it makes the examples easier
let x: Result<i32, i32> = Ok(42);
x.is_ok();
x.is_err();
x.is_err();
x.is_ok();
// Don't lint
match x {
Err(16) => false,
_ => true,
};
// Don't lint
match x {
Ok(16) => false,
_ => true,
};
}
fn issue10803() {
let x: Result<i32, i32> = Ok(42);
let _ = x.is_ok();
//~^ redundant_pattern_matching
let _ = x.is_err();
//~^ redundant_pattern_matching
// Don't lint
let _ = matches!(x, Ok(16));
// Don't lint
let _ = matches!(x, Err(16));
}
|
