1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
|
#![allow(dead_code, clippy::explicit_auto_deref, clippy::useless_vec, clippy::manual_contains)]
#![warn(clippy::search_is_some)]
fn main() {
let v = vec![3, 2, 1, 0, -1, -2, -3];
let y = &&42;
// Check `find().is_some()`, single-line case.
let _ = v.iter().find(|&x| *x < 0).is_some();
//~^ search_is_some
let _ = (0..1).find(|x| **y == *x).is_some(); // one dereference less
//
//~^^ search_is_some
let _ = (0..1).find(|x| *x == 0).is_some();
//~^ search_is_some
let _ = v.iter().find(|x| **x == 0).is_some();
//~^ search_is_some
let _ = (4..5).find(|x| *x == 1 || *x == 3 || *x == 5).is_some();
//~^ search_is_some
let _ = (1..3).find(|x| [1, 2, 3].contains(x)).is_some();
//~^ search_is_some
let _ = (1..3).find(|x| *x == 0 || [1, 2, 3].contains(x)).is_some();
//~^ search_is_some
let _ = (1..3).find(|x| [1, 2, 3].contains(x) || *x == 0).is_some();
//~^ search_is_some
let _ = (1..3)
.find(|x| [1, 2, 3].contains(x) || *x == 0 || [4, 5, 6].contains(x) || *x == -1)
//~^ search_is_some
.is_some();
// Check `position().is_some()`, single-line case.
let _ = v.iter().position(|&x| x < 0).is_some();
//~^ search_is_some
// Check `rposition().is_some()`, single-line case.
let _ = v.iter().rposition(|&x| x < 0).is_some();
//~^ search_is_some
let s1 = String::from("hello world");
let s2 = String::from("world");
// caller of `find()` is a `&`static str`
let _ = "hello world".find("world").is_some();
//~^ search_is_some
let _ = "hello world".find(&s2).is_some();
//~^ search_is_some
let _ = "hello world".find(&s2[2..]).is_some();
//~^ search_is_some
// caller of `find()` is a `String`
let _ = s1.find("world").is_some();
//~^ search_is_some
let _ = s1.find(&s2).is_some();
//~^ search_is_some
let _ = s1.find(&s2[2..]).is_some();
//~^ search_is_some
// caller of `find()` is slice of `String`
let _ = s1[2..].find("world").is_some();
//~^ search_is_some
let _ = s1[2..].find(&s2).is_some();
//~^ search_is_some
let _ = s1[2..].find(&s2[2..]).is_some();
//~^ search_is_some
}
#[allow(clippy::clone_on_copy, clippy::map_clone)]
mod issue7392 {
struct Player {
hand: Vec<usize>,
}
fn filter() {
let p = Player {
hand: vec![1, 2, 3, 4, 5],
};
let filter_hand = vec![5];
let _ = p
.hand
.iter()
.filter(|c| filter_hand.iter().find(|cc| c == cc).is_some())
//~^ search_is_some
.map(|c| c.clone())
.collect::<Vec<_>>();
}
struct PlayerTuple {
hand: Vec<(usize, char)>,
}
fn filter_tuple() {
let p = PlayerTuple {
hand: vec![(1, 'a'), (2, 'b'), (3, 'c'), (4, 'd'), (5, 'e')],
};
let filter_hand = vec![5];
let _ = p
.hand
.iter()
.filter(|(c, _)| filter_hand.iter().find(|cc| c == *cc).is_some())
//~^ search_is_some
.map(|c| c.clone())
.collect::<Vec<_>>();
}
fn field_projection() {
struct Foo {
foo: i32,
bar: u32,
}
let vfoo = vec![Foo { foo: 1, bar: 2 }];
let _ = vfoo.iter().find(|v| v.foo == 1 && v.bar == 2).is_some();
//~^ search_is_some
let vfoo = vec![(42, Foo { foo: 1, bar: 2 })];
let _ = vfoo
.iter()
.find(|(i, v)| *i == 42 && v.foo == 1 && v.bar == 2)
//~^ search_is_some
.is_some();
}
fn index_projection() {
let vfoo = vec![[0, 1, 2, 3]];
let _ = vfoo.iter().find(|a| a[0] == 42).is_some();
//~^ search_is_some
}
#[allow(clippy::match_like_matches_macro)]
fn slice_projection() {
let vfoo = vec![[0, 1, 2, 3, 0, 1, 2, 3]];
let _ = vfoo.iter().find(|sub| sub[1..4].len() == 3).is_some();
//~^ search_is_some
}
fn please(x: &u32) -> bool {
*x == 9
}
fn deref_enough(x: u32) -> bool {
x == 78
}
fn arg_no_deref(x: &&u32) -> bool {
**x == 78
}
fn more_projections() {
let x = 19;
let ppx: &u32 = &x;
let _ = [ppx].iter().find(|ppp_x: &&&u32| please(**ppp_x)).is_some();
//~^ search_is_some
let _ = [String::from("Hey hey")].iter().find(|s| s.len() == 2).is_some();
//~^ search_is_some
let v = vec![3, 2, 1, 0];
let _ = v.iter().find(|x| deref_enough(**x)).is_some();
//~^ search_is_some
let _ = v.iter().find(|x: &&u32| deref_enough(**x)).is_some();
//~^ search_is_some
#[allow(clippy::redundant_closure)]
let _ = v.iter().find(|x| arg_no_deref(x)).is_some();
//~^ search_is_some
#[allow(clippy::redundant_closure)]
let _ = v.iter().find(|x: &&u32| arg_no_deref(x)).is_some();
//~^ search_is_some
}
fn field_index_projection() {
struct FooDouble {
bar: Vec<Vec<i32>>,
}
struct Foo {
bar: Vec<i32>,
}
struct FooOuter {
inner: Foo,
inner_double: FooDouble,
}
let vfoo = vec![FooOuter {
inner: Foo { bar: vec![0, 1, 2, 3] },
inner_double: FooDouble {
bar: vec![vec![0, 1, 2, 3]],
},
}];
let _ = vfoo
.iter()
.find(|v| v.inner_double.bar[0][0] == 2 && v.inner.bar[0] == 2)
//~^ search_is_some
.is_some();
}
fn index_field_projection() {
struct Foo {
bar: i32,
}
struct FooOuter {
inner: Vec<Foo>,
}
let vfoo = vec![FooOuter {
inner: vec![Foo { bar: 0 }],
}];
let _ = vfoo.iter().find(|v| v.inner[0].bar == 2).is_some();
//~^ search_is_some
}
fn double_deref_index_projection() {
let vfoo = vec![&&[0, 1, 2, 3]];
let _ = vfoo.iter().find(|x| (**x)[0] == 9).is_some();
//~^ search_is_some
}
fn method_call_by_ref() {
struct Foo {
bar: u32,
}
impl Foo {
pub fn by_ref(&self, x: &u32) -> bool {
*x == self.bar
}
}
let vfoo = vec![Foo { bar: 1 }];
let _ = vfoo.iter().find(|v| v.by_ref(&v.bar)).is_some();
//~^ search_is_some
}
fn ref_bindings() {
let _ = [&(&1, 2), &(&3, 4), &(&5, 4)]
.iter()
.find(|&&&(&x, ref y)| x == *y)
//~^ search_is_some
.is_some();
}
fn test_string_1(s: &str) -> bool {
s.is_empty()
}
fn test_u32_1(s: &u32) -> bool {
s.is_power_of_two()
}
fn test_u32_2(s: u32) -> bool {
s.is_power_of_two()
}
fn projection_in_args_test() {
// Index projections
let lst = &[String::from("Hello"), String::from("world")];
let v: Vec<&[String]> = vec![lst];
let _ = v.iter().find(|s| s[0].is_empty()).is_some();
//~^ search_is_some
let _ = v.iter().find(|s| test_string_1(&s[0])).is_some();
//~^ search_is_some
// Field projections
struct FieldProjection<'a> {
field: &'a u32,
}
let field = 123456789;
let instance = FieldProjection { field: &field };
let v = vec![instance];
let _ = v.iter().find(|fp| fp.field.is_power_of_two()).is_some();
//~^ search_is_some
let _ = v.iter().find(|fp| test_u32_1(fp.field)).is_some();
//~^ search_is_some
let _ = v.iter().find(|fp| test_u32_2(*fp.field)).is_some();
//~^ search_is_some
}
}
mod issue9120 {
fn make_arg_no_deref_impl() -> impl Fn(&&u32) -> bool {
move |x: &&u32| **x == 78
}
fn make_arg_no_deref_dyn() -> Box<dyn Fn(&&u32) -> bool> {
Box::new(move |x: &&u32| **x == 78)
}
fn wrapper<T: Fn(&&u32) -> bool>(v: Vec<u32>, func: T) -> bool {
#[allow(clippy::redundant_closure)]
v.iter().find(|x: &&u32| func(x)).is_some()
//~^ search_is_some
}
fn do_tests() {
let v = vec![3, 2, 1, 0];
let arg_no_deref_impl = make_arg_no_deref_impl();
let arg_no_deref_dyn = make_arg_no_deref_dyn();
#[allow(clippy::redundant_closure)]
let _ = v.iter().find(|x: &&u32| arg_no_deref_impl(x)).is_some();
//~^ search_is_some
#[allow(clippy::redundant_closure)]
let _ = v.iter().find(|x: &&u32| arg_no_deref_dyn(x)).is_some();
//~^ search_is_some
#[allow(clippy::redundant_closure)]
let _ = v.iter().find(|x: &&u32| (*arg_no_deref_dyn)(x)).is_some();
//~^ search_is_some
}
}
fn issue15102() {
let values = [None, Some(3)];
let has_even = values.iter().find(|v| matches!(v, Some(x) if x % 2 == 0)).is_some();
//~^ search_is_some
println!("{has_even}");
}
|
