blob: 575cfda139a4ce2213c32138f2f76f404091b164 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
|
#![allow(unused)]
#![allow(clippy::nonminimal_bool)]
#![allow(clippy::needless_borrow)]
#![warn(clippy::set_contains_or_insert)]
use std::collections::{BTreeSet, HashSet};
fn should_warn_hashset() {
let mut set = HashSet::new();
let value = 5;
if !set.contains(&value) {
//~^ set_contains_or_insert
set.insert(value);
println!("Just a comment");
}
if set.contains(&value) {
//~^ set_contains_or_insert
set.insert(value);
println!("Just a comment");
}
if !set.contains(&value) {
//~^ set_contains_or_insert
set.insert(value);
}
if !!set.contains(&value) {
//~^ set_contains_or_insert
set.insert(value);
println!("Just a comment");
}
if (&set).contains(&value) {
//~^ set_contains_or_insert
set.insert(value);
}
let borrow_value = &6;
if !set.contains(borrow_value) {
//~^ set_contains_or_insert
set.insert(*borrow_value);
}
let borrow_set = &mut set;
if !borrow_set.contains(&value) {
//~^ set_contains_or_insert
borrow_set.insert(value);
}
}
fn should_not_warn_hashset() {
let mut set = HashSet::new();
let value = 5;
let another_value = 6;
if !set.contains(&value) {
set.insert(another_value);
}
if !set.contains(&value) {
println!("Just a comment");
}
if simply_true() {
set.insert(value);
}
if !set.contains(&value) {
set.replace(value); //it is not insert
println!("Just a comment");
}
if set.contains(&value) {
println!("value is already in set");
} else {
set.insert(value);
}
}
fn should_warn_btreeset() {
let mut set = BTreeSet::new();
let value = 5;
if !set.contains(&value) {
//~^ set_contains_or_insert
set.insert(value);
println!("Just a comment");
}
if set.contains(&value) {
//~^ set_contains_or_insert
set.insert(value);
println!("Just a comment");
}
if !set.contains(&value) {
//~^ set_contains_or_insert
set.insert(value);
}
if !!set.contains(&value) {
//~^ set_contains_or_insert
set.insert(value);
println!("Just a comment");
}
if (&set).contains(&value) {
//~^ set_contains_or_insert
set.insert(value);
}
let borrow_value = &6;
if !set.contains(borrow_value) {
//~^ set_contains_or_insert
set.insert(*borrow_value);
}
let borrow_set = &mut set;
if !borrow_set.contains(&value) {
//~^ set_contains_or_insert
borrow_set.insert(value);
}
}
fn should_not_warn_btreeset() {
let mut set = BTreeSet::new();
let value = 5;
let another_value = 6;
if !set.contains(&value) {
set.insert(another_value);
}
if !set.contains(&value) {
println!("Just a comment");
}
if simply_true() {
set.insert(value);
}
if !set.contains(&value) {
set.replace(value); //it is not insert
println!("Just a comment");
}
if set.contains(&value) {
println!("value is already in set");
} else {
set.insert(value);
}
}
fn simply_true() -> bool {
true
}
// This is placed last in order to be able to add new tests without changing line numbers
fn main() {
should_warn_hashset();
should_warn_btreeset();
should_not_warn_hashset();
should_not_warn_btreeset();
}
|
