about summary refs log tree commit diff
path: root/src/tools/clippy/tests/ui/suspicious_else_formatting.rs
blob: 072e7b27b0d0afa9390606299e5fb259b6b625e5 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
//@aux-build:proc_macro_suspicious_else_formatting.rs

#![warn(clippy::suspicious_else_formatting, clippy::possible_missing_else)]
#![allow(
    clippy::if_same_then_else,
    clippy::let_unit_value,
    clippy::needless_if,
    clippy::needless_else
)]

extern crate proc_macro_suspicious_else_formatting;
use proc_macro_suspicious_else_formatting::DeriveBadSpan;

fn foo() -> bool {
    true
}

#[rustfmt::skip]
fn main() {
    // weird `else` formatting:
    if foo() {
    } {
    //~^ possible_missing_else
    }

    if foo() {
    } if foo() {
    //~^ possible_missing_else
    }

    let _ = { // if as the last expression
        let _ = 0;

        if foo() {
        } if foo() {
        //~^ possible_missing_else
        }
        else {
        }
    };

    let _ = { // if in the middle of a block
        if foo() {
        } if foo() {
        //~^ possible_missing_else
        }
        else {
        }

        let _ = 0;
    };

    if foo() {
    } else
    {
    }
    //~^^^ suspicious_else_formatting

    // This is fine, though weird. Allman style braces on the else.
    if foo() {
    }
    else
    {
    }

    if foo() {
    } else
    if foo() { // the span of the above error should continue here
    }
    //~^^^ suspicious_else_formatting

    if foo() {
    }
    else
    if foo() { // the span of the above error should continue here
    }
    //~^^^^ suspicious_else_formatting

    // those are ok:
    if foo() {
    }
    {
    }

    if foo() {
    } else {
    }

    if foo() {
    }
    else {
    }

    if foo() {
    }
    if foo() {
    }

    // Almost Allman style braces. Lint these.
    if foo() {
    }

    else
    {
    }
    //~^^^^^ suspicious_else_formatting

    if foo() {
    }
    else

    {

    }
    //~^^^^^^ suspicious_else_formatting

    // #3864 - Allman style braces
    if foo()
    {
    }
    else
    {
    }

    //#10273 This is fine. Don't warn
    if foo() {
    } else
    /* whelp */
    {
    }

    // #12497 Don't trigger lint as rustfmt wants it
    if true {
        println!("true");
    }
    /*else if false {
}*/
    else {
        println!("false");
    }

    if true {
        println!("true");
    } // else if false {}
    else {
        println!("false");
    }

    if true {
        println!("true");
    } /* if true {
        println!("true");
}
    */
    else {
        println!("false");
    }

}

// #7650 - Don't lint. Proc-macro using bad spans for `if` expressions.
#[derive(DeriveBadSpan)]
struct _Foo(u32, u32);