about summary refs log tree commit diff
path: root/src/tools/clippy/tests/ui/unit_cmp.rs
blob: 0a0fe3a1990b08779477b842a2dffbbefcaab413 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
#![warn(clippy::unit_cmp)]
#![allow(
    clippy::no_effect,
    clippy::unnecessary_operation,
    clippy::derive_partial_eq_without_eq,
    clippy::needless_if
)]

#[derive(PartialEq)]
pub struct ContainsUnit(()); // should be fine

fn main() {
    // this is fine
    if true == false {}

    // this warns
    if {
        //~^ unit_cmp

        true;
    } == {
        false;
    } {}

    if {
        //~^ unit_cmp

        true;
    } > {
        false;
    } {}

    assert_eq!(
        //~^ unit_cmp
        {
            true;
        },
        {
            false;
        }
    );
    debug_assert_eq!(
        //~^ unit_cmp
        {
            true;
        },
        {
            false;
        }
    );

    assert_ne!(
        //~^ unit_cmp
        {
            true;
        },
        {
            false;
        }
    );
    debug_assert_ne!(
        //~^ unit_cmp
        {
            true;
        },
        {
            false;
        }
    );
}

fn issue15559() {
    fn foo() {}
    assert_eq!(
        //~^ unit_cmp
        {
            1;
        },
        foo()
    );
    assert_eq!(foo(), foo());
    //~^ unit_cmp

    // don't lint on explicitly written unit expr
    assert_eq!(foo(), ());
    assert_ne!((), ContainsUnit(()).0);
}