1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
|
#![warn(clippy::unnecessary_literal_unwrap)]
#![allow(unreachable_code)]
#![allow(
clippy::unnecessary_lazy_evaluations,
clippy::diverging_sub_expression,
clippy::let_unit_value,
clippy::no_effect
)]
fn unwrap_option_some() {
let _val = Some(1).unwrap();
//~^ unnecessary_literal_unwrap
let _val = Some(1).expect("this never happens");
//~^ unnecessary_literal_unwrap
Some(1).unwrap();
//~^ unnecessary_literal_unwrap
Some(1).expect("this never happens");
//~^ unnecessary_literal_unwrap
}
#[rustfmt::skip] // force rustfmt not to remove braces in `|| { 234 }`
fn unwrap_option_none() {
let _val = None::<()>.unwrap();
//~^ unnecessary_literal_unwrap
let _val = None::<()>.expect("this always happens");
//~^ unnecessary_literal_unwrap
let _val: String = None.unwrap_or_default();
//~^ unnecessary_literal_unwrap
let _val: u16 = None.unwrap_or(234);
//~^ unnecessary_literal_unwrap
let _val: u16 = None.unwrap_or_else(|| 234);
//~^ unnecessary_literal_unwrap
let _val: u16 = None.unwrap_or_else(|| { 234 });
//~^ unnecessary_literal_unwrap
let _val: u16 = None.unwrap_or_else(|| -> u16 { 234 });
//~^ unnecessary_literal_unwrap
None::<()>.unwrap();
//~^ unnecessary_literal_unwrap
None::<()>.expect("this always happens");
//~^ unnecessary_literal_unwrap
None::<String>.unwrap_or_default();
//~^ unnecessary_literal_unwrap
None::<u16>.unwrap_or(234);
//~^ unnecessary_literal_unwrap
None::<u16>.unwrap_or_else(|| 234);
//~^ unnecessary_literal_unwrap
None::<u16>.unwrap_or_else(|| { 234 });
//~^ unnecessary_literal_unwrap
None::<u16>.unwrap_or_else(|| -> u16 { 234 });
//~^ unnecessary_literal_unwrap
}
fn unwrap_result_ok() {
let _val = Ok::<_, ()>(1).unwrap();
//~^ unnecessary_literal_unwrap
let _val = Ok::<_, ()>(1).expect("this never happens");
//~^ unnecessary_literal_unwrap
let _val = Ok::<_, ()>(1).unwrap_err();
//~^ unnecessary_literal_unwrap
let _val = Ok::<_, ()>(1).expect_err("this always happens");
//~^ unnecessary_literal_unwrap
Ok::<_, ()>(1).unwrap();
//~^ unnecessary_literal_unwrap
Ok::<_, ()>(1).expect("this never happens");
//~^ unnecessary_literal_unwrap
Ok::<_, ()>(1).unwrap_err();
//~^ unnecessary_literal_unwrap
Ok::<_, ()>(1).expect_err("this always happens");
//~^ unnecessary_literal_unwrap
}
fn unwrap_result_err() {
let _val = Err::<(), _>(1).unwrap_err();
//~^ unnecessary_literal_unwrap
let _val = Err::<(), _>(1).expect_err("this never happens");
//~^ unnecessary_literal_unwrap
let _val = Err::<(), _>(1).unwrap();
//~^ unnecessary_literal_unwrap
let _val = Err::<(), _>(1).expect("this always happens");
//~^ unnecessary_literal_unwrap
Err::<(), _>(1).unwrap_err();
//~^ unnecessary_literal_unwrap
Err::<(), _>(1).expect_err("this never happens");
//~^ unnecessary_literal_unwrap
Err::<(), _>(1).unwrap();
//~^ unnecessary_literal_unwrap
Err::<(), _>(1).expect("this always happens");
//~^ unnecessary_literal_unwrap
}
fn unwrap_methods_option() {
let _val = Some(1).unwrap_or(2);
//~^ unnecessary_literal_unwrap
let _val = Some(1).unwrap_or_default();
//~^ unnecessary_literal_unwrap
let _val = Some(1).unwrap_or_else(|| 2);
//~^ unnecessary_literal_unwrap
Some(1).unwrap_or(2);
//~^ unnecessary_literal_unwrap
Some(1).unwrap_or_default();
//~^ unnecessary_literal_unwrap
Some(1).unwrap_or_else(|| 2);
//~^ unnecessary_literal_unwrap
}
fn unwrap_methods_result() {
let _val = Ok::<_, ()>(1).unwrap_or(2);
//~^ unnecessary_literal_unwrap
let _val = Ok::<_, ()>(1).unwrap_or_default();
//~^ unnecessary_literal_unwrap
let _val = Ok::<_, ()>(1).unwrap_or_else(|_| 2);
//~^ unnecessary_literal_unwrap
Ok::<_, ()>(1).unwrap_or(2);
//~^ unnecessary_literal_unwrap
Ok::<_, ()>(1).unwrap_or_default();
//~^ unnecessary_literal_unwrap
Ok::<_, ()>(1).unwrap_or_else(|_| 2);
//~^ unnecessary_literal_unwrap
}
fn unwrap_from_binding() {
macro_rules! from_macro {
() => {
Some("")
};
}
let val = from_macro!();
let _ = val.unwrap_or("");
}
fn unwrap_unchecked() {
let _ = unsafe { Some(1).unwrap_unchecked() };
//~^ unnecessary_literal_unwrap
let _ = unsafe { Some(1).unwrap_unchecked() + *(&1 as *const i32) }; // needs to keep the unsafe block
//
//~^^ unnecessary_literal_unwrap
let _ = unsafe { Some(1).unwrap_unchecked() } + 1;
//~^ unnecessary_literal_unwrap
let _ = unsafe { Ok::<_, ()>(1).unwrap_unchecked() };
//~^ unnecessary_literal_unwrap
let _ = unsafe { Ok::<_, ()>(1).unwrap_unchecked() + *(&1 as *const i32) };
//~^ unnecessary_literal_unwrap
let _ = unsafe { Ok::<_, ()>(1).unwrap_unchecked() } + 1;
//~^ unnecessary_literal_unwrap
let _ = unsafe { Err::<(), i32>(123).unwrap_err_unchecked() };
//~^ unnecessary_literal_unwrap
}
fn main() {
unwrap_option_some();
unwrap_option_none();
unwrap_result_ok();
unwrap_result_err();
unwrap_methods_option();
unwrap_methods_result();
unwrap_unchecked();
}
|
