1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
|
#![warn(clippy::unwrap_or_default)]
#![allow(dead_code)]
#![allow(clippy::unnecessary_wraps, clippy::unnecessary_literal_unwrap)]
/// Checks implementation of the `UNWRAP_OR_DEFAULT` lint.
fn unwrap_or_else_default() {
struct Foo;
impl Foo {
fn new() -> Foo {
Foo
}
// fake default, we should not trigger on this
fn default() -> Foo {
Foo
}
}
struct HasDefaultAndDuplicate;
impl HasDefaultAndDuplicate {
fn default() -> Self {
HasDefaultAndDuplicate
}
}
impl Default for HasDefaultAndDuplicate {
fn default() -> Self {
HasDefaultAndDuplicate
}
}
enum Enum {
A(),
}
fn make<T, V>(_: V) -> T {
unimplemented!();
}
let with_enum = Some(Enum::A());
with_enum.unwrap_or_else(Enum::A);
let with_new = Some(vec![1]);
with_new.unwrap_or_default();
//~^ unwrap_or_default
let with_err: Result<_, ()> = Ok(vec![1]);
with_err.unwrap_or_else(make);
// should not be changed
let with_fake_default = None::<Foo>;
with_fake_default.unwrap_or_else(Foo::default);
// should not be changed
let with_fake_default2 = None::<HasDefaultAndDuplicate>;
with_fake_default2.unwrap_or_else(<HasDefaultAndDuplicate>::default);
let with_real_default = None::<HasDefaultAndDuplicate>;
with_real_default.unwrap_or_default();
//~^ unwrap_or_default
let with_default_trait = Some(1);
with_default_trait.unwrap_or_default();
//~^ unwrap_or_default
let with_default_type = Some(1);
with_default_type.unwrap_or_default();
//~^ unwrap_or_default
let with_default_type: Option<Vec<u64>> = None;
with_default_type.unwrap_or_default();
//~^ unwrap_or_default
let empty_string = None::<String>;
empty_string.unwrap_or_default();
//~^ unwrap_or_default
}
fn type_certainty(option: Option<Vec<u64>>) {
option.unwrap_or_default().push(1);
//~^ unwrap_or_default
let option: std::option::Option<std::vec::Vec<u64>> = None;
option.unwrap_or_default().push(1);
//~^ unwrap_or_default
let option: Option<Vec<u64>> = None;
option.unwrap_or_default().push(1);
//~^ unwrap_or_default
let option = std::option::Option::<std::vec::Vec<u64>>::None;
option.unwrap_or_default().push(1);
//~^ unwrap_or_default
let option = Option::<Vec<u64>>::None;
option.unwrap_or_default().push(1);
//~^ unwrap_or_default
let option = std::option::Option::None::<std::vec::Vec<u64>>;
option.unwrap_or_default().push(1);
//~^ unwrap_or_default
let option = Option::None::<Vec<u64>>;
option.unwrap_or_default().push(1);
//~^ unwrap_or_default
let option = None::<Vec<u64>>;
option.unwrap_or_default().push(1);
//~^ unwrap_or_default
// should not be changed: type annotation with infer, unconcretized initializer
let option: Option<Vec<_>> = None;
option.unwrap_or_else(Vec::new).push(1);
// should not be changed: no type annotation, unconcretized initializer
let option = Option::None;
option.unwrap_or_else(Vec::new).push(1);
// should not be changed: no type annotation, unconcretized initializer
let option = None;
option.unwrap_or_else(Vec::new).push(1);
type Alias = Option<Vec<u32>>;
let option: Alias = Option::<Vec<u32>>::Some(Vec::new());
option.unwrap_or_default().push(1);
//~^ unwrap_or_default
}
fn method_call_with_deref() {
use std::cell::RefCell;
use std::collections::HashMap;
let cell = RefCell::new(HashMap::<u64, HashMap<u64, String>>::new());
let mut outer_map = cell.borrow_mut();
#[allow(unused_assignments)]
let mut option = None;
option = Some(0);
let inner_map = outer_map.get_mut(&option.unwrap()).unwrap();
let _ = inner_map.entry(0).or_default();
//~^ unwrap_or_default
}
fn missing_suggested_method() {
#[derive(Copy, Clone)]
struct S<T>(T);
impl<T> S<T> {
fn or_insert_with(&mut self, default: impl FnOnce() -> T) -> &mut T {
&mut self.0
}
fn or_insert(&mut self, default: T) -> &mut T {
&mut self.0
}
fn unwrap_or_else(self, default: impl FnOnce() -> T) -> T {
self.0
}
fn unwrap_or(self, default: T) -> T {
self.0
}
}
// Don't lint when or_default/unwrap_or_default do not exist on the type
let mut s = S(1);
s.or_insert_with(Default::default);
s.or_insert(Default::default());
s.unwrap_or_else(Default::default);
s.unwrap_or(Default::default());
}
fn main() {}
|
