blob: 617535393bb5ccc7adf0bac8a3b9a9c306454e79 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
|
tree c0271bccd902abfbbc429e186d208b9a92ca79db
parent d8578bf9bf36708ca0095c77e2856c78ed3fd8ec
parent 09fc5e1dd7f8635d111c12e745cf782fe3b58d95
author bors[bot] <26634292+bors[bot]@users.noreply.github.com> 1619385537 +0000
committer GitHub <noreply@github.com> 1619385537 +0000
gpgsig -----BEGIN PGP SIGNATURE-----
wsBcBAABCAAQBQJghdzBCRBK7hj4Ov3rIwAAcCQIADI0slPoolio3lvibHVfSuIe
uVi/cXvm9kOKIb97WP3e4FGoQPYdfAoY+KTrIlasUGGqjVKK2Zf0Tu60lLEbO3Eo
Rp34Zs3z8helAKMUKF3U/IiFkGfZkcavThi8VvATrYgiY2sRp+usWQXm1LhM4j9N
Px62kqvce1wUbOjCvTsLsrvLHcluDVHxtUgrq28cw9V5W1LfY9R0tozt/SBhCb7a
7+Q8bO/61wh4X+vqUYjT25rF75x7FNlQYRuZHf1b2c3rFaHSmlDodYO9+m9ug1Bk
r+5eMp6zylEFERNyGnDgO4Jn9dGUvVupNhh91gBLvdxIM1RiBtQIPbq2D0TeWT8=
=dD5z
-----END PGP SIGNATURE-----
Merge #8658
8658: Check more carefully for cases where a rename can't be done r=Veykril a=dzhu
Attempting to rename an element of a tuple field would previously replace the type with the new name, which doesn't make sense; now it fails instead.
The check is done in both `prepare_rename` and `rename` so that the case is caught before the user is prompted for a new name. Some other existing failure cases are also now additionally checked in `prepare_rename`.
Closes: #8592
(I threw in some doc edits for a relevant type; of course, I can remove those if the policy here is to be strict about scope of changes within a PR.)
Co-authored-by: Danny Zhu <dzhu@dzhu.us>
|
