diff options
| author | Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> | 2023-05-04 00:17:26 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-04 00:17:26 +0530 |
| commit | a47fa34558e34811508e00c5b67a0c49d595de98 (patch) | |
| tree | 0338aa86ae17d60546628c9b81efb327fe04208d | |
| parent | fce0741fe9a3c6904608dd04ef8a25d8ceb6ca35 (diff) | |
| parent | bc68de94c87537edd43f22606d84e8a2ad48e413 (diff) | |
| download | rust-a47fa34558e34811508e00c5b67a0c49d595de98.tar.gz rust-a47fa34558e34811508e00c5b67a0c49d595de98.zip | |
Rollup merge of #111069 - ozkanonur:remove-pointless-fixme, r=albertlarsan68
remove pointless `FIXME` in `bootstrap::download` The suggestion given by `FIXME` to use `CompilerMetadata` for `download_toolchain` in `bootstrap::download` can result in more confusion. This is because `stamp_key` is not always a date; it can also be a commit hash. Additionally, unlike in `download_beta_toolchain`, in the `download_ci_rustc` function, `version` and `commit` values are calculated separately.
| -rw-r--r-- | src/bootstrap/download.rs | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/bootstrap/download.rs b/src/bootstrap/download.rs index c1cf9b93fb3..3e82a381a1b 100644 --- a/src/bootstrap/download.rs +++ b/src/bootstrap/download.rs @@ -427,7 +427,6 @@ impl Config { fn download_toolchain( &self, - // FIXME(ozkanonur) use CompilerMetadata instead of `version: &str` version: &str, sysroot: &str, stamp_key: &str, |