diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2024-02-17 18:47:40 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-17 18:47:40 +0100 |
| commit | e9aa2540c357525523619efda952c097e0de0d09 (patch) | |
| tree | 31a242b3cd20883c0931122470a94e22efb675ca | |
| parent | 64dfa4f455ed72e1c17a82fa67a577b869ed5992 (diff) | |
| parent | ec5328b3d9aa08986abd3237b40c0bf74b08bc2b (diff) | |
| download | rust-e9aa2540c357525523619efda952c097e0de0d09.tar.gz rust-e9aa2540c357525523619efda952c097e0de0d09.zip | |
Rollup merge of #121085 - davidtwco:always-eager-diagnostics, r=nnethercote
errors: only eagerly translate subdiagnostics Subdiagnostics don't need to be lazily translated, they can always be eagerly translated. Eager translation is slightly more complex as we need to have a `DiagCtxt` available to perform the translation, which involves slightly more threading of that context. This slight increase in complexity should enable later simplifications - like passing `DiagCtxt` into `AddToDiagnostic` and moving Fluent messages into the diagnostic structs rather than having them in separate files (working on that was what led to this change). r? ```@nnethercote```
| -rw-r--r-- | src/errors.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/errors.rs b/src/errors.rs index cc0fbe46dcc..79eb4406b8a 100644 --- a/src/errors.rs +++ b/src/errors.rs @@ -122,7 +122,7 @@ impl<G: EmissionGuarantee> IntoDiagnostic<'_, G> for TargetFeatureDisableOrEnabl diag.span(span); }; if let Some(missing_features) = self.missing_features { - diag.subdiagnostic(missing_features); + diag.subdiagnostic(dcx, missing_features); } diag.arg("features", self.features.join(", ")); diag |