about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src
diff options
context:
space:
mode:
authorDylan DPC <dylan.dpc@gmail.com>2021-04-02 19:57:33 +0200
committerGitHub <noreply@github.com>2021-04-02 19:57:33 +0200
commit70091171bd823cac1d3131cd6aea0f191d99a998 (patch)
tree93a48b5a6b4f34c401af7f60f91a3b4a9fa1c45f /compiler/rustc_codegen_llvm/src
parent6cb74ad99f8f6cc994ebe18d906ec1dd7ccd8b3d (diff)
parentfad53880394f0cb4a8e2367fcc218c1fa55539d6 (diff)
downloadrust-70091171bd823cac1d3131cd6aea0f191d99a998.tar.gz
rust-70091171bd823cac1d3131cd6aea0f191d99a998.zip
Rollup merge of #83755 - richkadel:cov-test-simplify, r=tmandry
Simplify coverage tests

This change reduces the risk of impacting coverage tests on unrelated
changes (such as MIR and Span changes), and reduces the burden when
blessing coverage changes in case it is necessary.

* Remove all spanview tests. The spanview tests were useful during
  development, but they can be generated as needed, via compiler command
  line flags. They aren't critical to confirming coverage results. (The
  coverage report tests are sufficient.)

  When spanview regeneration was necessary, the diffs were way too hard
  to read to be useful anyway. So I'm removing them to reduce friction
  from a feature that is no longer useful.

* Remove the requirement for `llvm-cov show --debug` when blessing
  tests. The `--debug` flag is, unfortunately, only available if LLVM is
  built with `optimize = false` (in Rust's config.toml). This adds
  significant time and resource burdens to the contributor's build. As
  it turns out, for other reasons in the past, I wasn't actually using
  the debug output (counter info) to validate coverage anymore either,
  so it was required for no reason, I now realize.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions