diff options
| author | Chris Denton <chris@chrisdenton.dev> | 2025-04-28 01:58:49 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-04-28 01:58:49 +0000 |
| commit | 8ee9029f673d0d495ab156078216828aaed7095c (patch) | |
| tree | 8de43ef45040b8610ad6832c254caf3d7bbedcb2 /compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp | |
| parent | 55f93265f02da2bde836e9e382c5b3377454b806 (diff) | |
| parent | aa8670f6f81dac097d24277e7559ce5abf5d5183 (diff) | |
| download | rust-8ee9029f673d0d495ab156078216828aaed7095c.tar.gz rust-8ee9029f673d0d495ab156078216828aaed7095c.zip | |
Rollup merge of #139224 - epage:nocapture, r=thomcc
fix(test): Expose '--no-capture' in favor of `--nocapture` This improves consistency with commonly expected CLI conventions, avoiding a common stutter people make when running tests (trying what they expect and then having to check the docs to then user whats accepted). An alternative could have been to take a value, like `--capture <value>` (e.g. `pytest` does this). Overall, we're shifting focus for features to custom test harnesses (see #134283). Most of `pytest`s modes will likely be irrelevant in that situation. As for the rest, its too early to tell which, if any, may be relevant, so we're sticking with this small, quality of life improvement. I expect we'll warn about `--nocapture` being deprecated in the future after a sufficient transition period has been allowed. By deprecating `--nocapture`, we intend that custom test harnesses do not need to support it for reasons outside of their own compatibility requirements, much like the deprecation in #134283 I'm punting for now on the naming of `RUST_TEST_NOCAPTURE`. I feel like T-testing-devex should do a wider look at environment variables role in lib`test` before evaluating whether to - Deprecate it in favor of the user passing CLI flags or the test runner providing its own config - Deprecate in favor of `RUST_TEST_NO_CAPTURE` - Deprecate in favor of `RUST_TEST_CAPTURE` Other CLI flags were evaluated for casing consistency: - `--logfile` has the same problem but was deprecated in #134283 Regarding the implementation, I moved `--nocapture` out of `optgroups()`, into `parse_opts()`, out of an abundance of caution in passing the options without a deprecated value to the usage generation. However, the usage does not actually show optional flags, so this could potentially be dropped, simplifying the PR. Note: `compiletest` added `--no-capture` instead of `--nocapture` in #134809 T-testing-devex FCP: https://github.com/rust-lang/rust/issues/133073#issuecomment-2486921104 Fixes #133073
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp')
0 files changed, 0 insertions, 0 deletions
