diff options
| author | Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> | 2022-09-16 11:17:02 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-09-16 11:17:02 +0530 |
| commit | 458555dbf6e4847e8b4f19d31f37f45baf7fd128 (patch) | |
| tree | 6d6159c935e7b28ae536b5aadf72dad0f5238593 /compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp | |
| parent | cfef659d137e0491c3a1356ffd4dbd2968c18404 (diff) | |
| parent | f69a6c2a8018ac69db62446996e815893b70dfcd (diff) | |
| download | rust-458555dbf6e4847e8b4f19d31f37f45baf7fd128.tar.gz rust-458555dbf6e4847e8b4f19d31f37f45baf7fd128.zip | |
Rollup merge of #101809 - aDotInTheVoid:jsondoclint, r=GuillaumeGomez
Replace `check_missing_items.py` with `jsondoclint`
[zulip discussion](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/check_missing_items.2Epy.20Replacement.2E)
check_missing_items.py was a python script that checked rustdoc json output to make sure all the Id's referenced existed in the JSON index. This PR replaces that with a rust binary (`jsondoclint`) that does the same thing.
### Motivation
1. Easier to change when `rustdoc-json-types` changes, as `jsondoclint` uses the types directly.
2. Better Errors:
- Multiple Errors can be emited for a single crate
- Errors can say where in JSON they occored
```
2:2889:408 not in index or paths, but refered to at '.index."2:2888:104".inner.items[0]'
2:2890:410 not in index or paths, but refered to at '.index."2:2888:104".inner.items[1]'
```
3. Catches more bugs.
- Because matches are exaustive, all posible variants considered for enums
- All Id's checked
- Has already found #101770, #101199 and #100973
- Id type is also checked, so the Id's in a structs fields can only be field items.
4. Allows the possibility of running from `rustdoc::json`, which we should do in a crator run at some point.
cc ``@CraftSpider``
r? ``@GuillaumeGomez``
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions
