diff options
| author | Mazdak Farrokhzad <twingoow@gmail.com> | 2019-10-28 04:53:11 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-10-28 04:53:11 +0100 |
| commit | 75a127c48b8e940de145d6c70f24a81680394bdf (patch) | |
| tree | 5a257e27e8cbe54210a675eb6faeec6a533f43fd /src/liballoc | |
| parent | 575058f3d7ccba3c20080b55e0ca409a35607330 (diff) | |
| parent | 3f980785fb55e31aca9215faa474d751e5a28d69 (diff) | |
| download | rust-75a127c48b8e940de145d6c70f24a81680394bdf.tar.gz rust-75a127c48b8e940de145d6c70f24a81680394bdf.zip | |
Rollup merge of #65873 - lzutao:doc-vec-from-raw-parts, r=rkruppe
doc: explain why it is unsafe to construct Vec<u8> from Vec<u16>
Diffstat (limited to 'src/liballoc')
| -rw-r--r-- | src/liballoc/vec.rs | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/liballoc/vec.rs b/src/liballoc/vec.rs index 641f9eafa8d..5e733fa43d7 100644 --- a/src/liballoc/vec.rs +++ b/src/liballoc/vec.rs @@ -411,7 +411,11 @@ impl<T> Vec<T> { /// /// Violating these may cause problems like corrupting the allocator's /// internal data structures. For example it is **not** safe - /// to build a `Vec<u8>` from a pointer to a C `char` array and a `size_t`. + /// to build a `Vec<u8>` from a pointer to a C `char` array with length `size_t`. + /// It's also not safe to build one from a `Vec<u16>` and its length, because + /// the allocator cares about the alignment, and these two types have different + /// alignments. The buffer was allocated with alignment 2 (for `u16`), but after + /// turning it into a `Vec<u8>` it'll be deallocated with alignment 1. /// /// The ownership of `ptr` is effectively transferred to the /// `Vec<T>` which may then deallocate, reallocate or change the |
