about summary refs log tree commit diff
path: root/src/libstd/net
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2017-01-12 03:13:48 +0000
committerbors <bors@rust-lang.org>2017-01-12 03:13:48 +0000
commit2782e8f8fcefdce77c5e0dd0846c15c4c5103d84 (patch)
tree52c10ec4d33e51a4a27aa334a36157c29011f155 /src/libstd/net
parent1ca100d0428985f916eea153886762bed3909771 (diff)
parent7eb43f1b20d352c69cb888c39409786b7dd78ffe (diff)
downloadrust-2782e8f8fcefdce77c5e0dd0846c15c4c5103d84.tar.gz
rust-2782e8f8fcefdce77c5e0dd0846c15c4c5103d84.zip
Auto merge of #38867 - alexcrichton:ignore-test-on-windows, r=brson
std: Ignore close_read_wakes_up on Windows

It looks like in practice at least this test will not pass on Windows.
Empirically it is prone to blocking forever, presumably because a call to
`shutdown` doesn't actually wake up other threads on Windows.

We don't document this as a guarantee for `shutdown`, nor do we internally rely
on it. This test originated in a time long since passed when it was leveraged
for canceling I/O, but nowadays there's nothing fancy happening in the standard
library so it's not really a productive test anyway, hence just ignoring it on
Windows.

Closes #31657
Diffstat (limited to 'src/libstd/net')
-rw-r--r--src/libstd/net/tcp.rs1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/libstd/net/tcp.rs b/src/libstd/net/tcp.rs
index e203789ce81..cbc672c28bc 100644
--- a/src/libstd/net/tcp.rs
+++ b/src/libstd/net/tcp.rs
@@ -1153,6 +1153,7 @@ mod tests {
     }
 
     #[test]
+    #[cfg(unix)] // test doesn't work on Windows, see #31657
     fn close_read_wakes_up() {
         each_ip(&mut |addr| {
             let a = t!(TcpListener::bind(&addr));