diff options
| author | bors <bors@rust-lang.org> | 2017-03-23 09:18:11 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2017-03-23 09:18:11 +0000 |
| commit | 90346eae18e83887517e096c17678a74838ff995 (patch) | |
| tree | 97124d737d00126df01e1ae853878483103f52f6 /src/rustllvm/PassWrapper.cpp | |
| parent | c6df67afca788453a3c494899fbf5295992bcfba (diff) | |
| parent | ef90d32f07e187d3e1824d980ad01caac5313101 (diff) | |
| download | rust-90346eae18e83887517e096c17678a74838ff995.tar.gz rust-90346eae18e83887517e096c17678a74838ff995.zip | |
Auto merge of #40549 - alexcrichton:uwtable-everywhere, r=eddyb
rustc: Always emit the `uwtable` attribute on Windows This commit alters the translation layer to unconditionally emit the `uwtable` LLVM attribute on Windows regardless of the `no_landing_pads` setting. Previously I believe we omitted this attribute as an optimization when the `-Cpanic=abort` flag was passed, but this unfortunately caused problems for Gecko. It [was discovered] that there was trouble unwinding through Rust functions due to foreign exceptions such as illegal instructions or otherwise in-practice methods used to abort a process. In testing it looked like the major difference between a working binary and a non-working binary is indeed this `uwtable` attribute, but this PR has unfortunately not been thoroughly tested in terms of compiling Gecko with `-C panic=abort` *and* this PR to see whether it works, so this is still somewhat working on just suspicion. [was discovered]: https://bugzilla.mozilla.org/show_bug.cgi?id=1302078
Diffstat (limited to 'src/rustllvm/PassWrapper.cpp')
0 files changed, 0 insertions, 0 deletions
